From: tip-bot for Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, julia@diku.dk, hpa@zytor.com,
mingo@redhat.com, bzolnier@gmail.com, eteo@redhat.com,
corbet@lwn.net, error27@gmail.com, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq_resend()
Date: Sat, 8 Aug 2009 16:21:37 GMT [thread overview]
Message-ID: <tip-139183d579d6097cdbbd64825bbac54d8481a144@git.kernel.org> (raw)
In-Reply-To: <200908062146.03638.bzolnier@gmail.com>
Commit-ID: 139183d579d6097cdbbd64825bbac54d8481a144
Gitweb: http://git.kernel.org/tip/139183d579d6097cdbbd64825bbac54d8481a144
Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
AuthorDate: Thu, 6 Aug 2009 21:46:03 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 8 Aug 2009 18:18:05 +0200
irq: Remove superfluous NULL pointer check in check_irq_resend()
This takes care of the following entry from Dan's list:
kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Eugene Teo <eteo@redhat.com>
Cc: Julia Lawall <julia@diku.dk>
LKML-Reference: <200908062146.03638.bzolnier@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/irq/resend.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c
index 89c7117..090c376 100644
--- a/kernel/irq/resend.c
+++ b/kernel/irq/resend.c
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq)
if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {
desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;
- if (!desc->chip || !desc->chip->retrigger ||
- !desc->chip->retrigger(irq)) {
+ if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {
#ifdef CONFIG_HARDIRQS_SW_RESEND
/* Set it pending and activate the softirq: */
set_bit(irq, irqs_resend);
next prev parent reply other threads:[~2009-08-08 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 19:46 [PATCH] irq: remove superfluous NULL pointer check in check_irq_resend() Bartlomiej Zolnierkiewicz
2009-08-08 16:21 ` tip-bot for Bartlomiej Zolnierkiewicz [this message]
2009-08-09 10:45 ` [tip:irq/core] irq: Remove " tip-bot for Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-139183d579d6097cdbbd64825bbac54d8481a144@git.kernel.org \
--to=bzolnier@gmail.com \
--cc=corbet@lwn.net \
--cc=error27@gmail.com \
--cc=eteo@redhat.com \
--cc=hpa@zytor.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.