From: tip-bot for Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
xiaoguangrong@cn.fujitsu.com, rostedt@goodmis.org,
johannes@sipsolutions.net, tglx@linutronix.de, jbaron@redhat.com,
mingo@elte.hu, avi@redhat.com
Subject: [tip:perf/urgent] jump_label: Fix jump_label update for modules
Date: Fri, 1 Jul 2011 15:12:21 GMT [thread overview]
Message-ID: <tip-140fe3b1ab9c082182ef13359fab4ddba95c24c3@git.kernel.org> (raw)
In-Reply-To: <4E00038B.2060404@cn.fujitsu.com>
Commit-ID: 140fe3b1ab9c082182ef13359fab4ddba95c24c3
Gitweb: http://git.kernel.org/tip/140fe3b1ab9c082182ef13359fab4ddba95c24c3
Author: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
AuthorDate: Tue, 21 Jun 2011 10:35:55 +0800
Committer: Steven Rostedt <rostedt@goodmis.org>
CommitDate: Wed, 29 Jun 2011 09:59:17 -0400
jump_label: Fix jump_label update for modules
The jump labels entries for modules do not stop at __stop__jump_table,
but after mod->jump_entries + mod_num_jump_entries.
By checking the wrong end point, module trace events never get enabled.
Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Jason Baron <jbaron@redhat.com>
Tested-by: Avi Kivity <avi@redhat.com>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Link: http://lkml.kernel.org/r/4E00038B.2060404@cn.fujitsu.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/jump_label.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/jump_label.c b/kernel/jump_label.c
index fa27e75..a8ce450 100644
--- a/kernel/jump_label.c
+++ b/kernel/jump_label.c
@@ -375,15 +375,19 @@ int jump_label_text_reserved(void *start, void *end)
static void jump_label_update(struct jump_label_key *key, int enable)
{
- struct jump_entry *entry = key->entries;
-
- /* if there are no users, entry can be NULL */
- if (entry)
- __jump_label_update(key, entry, __stop___jump_table, enable);
+ struct jump_entry *entry = key->entries, *stop = __stop___jump_table;
#ifdef CONFIG_MODULES
+ struct module *mod = __module_address((jump_label_t)key);
+
__jump_label_mod_update(key, enable);
+
+ if (mod)
+ stop = mod->jump_entries + mod->num_jump_entries;
#endif
+ /* if there are no users, entry can be NULL */
+ if (entry)
+ __jump_label_update(key, entry, stop, enable);
}
#endif
prev parent reply other threads:[~2011-07-01 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 2:35 [PATCH v2] jump_label: fix jump_label update Xiao Guangrong
2011-06-21 9:44 ` Jiri Olsa
2011-06-21 15:47 ` Jason Baron
2011-06-21 15:44 ` Jason Baron
2011-06-23 12:22 ` Avi Kivity
2011-06-23 12:45 ` Avi Kivity
2011-06-23 17:44 ` Steven Rostedt
2011-07-01 15:12 ` tip-bot for Xiao Guangrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-140fe3b1ab9c082182ef13359fab4ddba95c24c3@git.kernel.org \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.