All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for David Rientjes <rientjes@google.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	torvalds@linux-foundation.org, peterz@infradead.org,
	lee.schermerhorn@hp.com, tglx@linutronix.de,
	sfr@canb.auug.org.au, rientjes@google.com
Subject: [tip:sched/numa] sched/numa: Allocate 'struct node_queue' on any node for offline nodes
Date: Wed, 23 May 2012 08:33:11 -0700	[thread overview]
Message-ID: <tip-183e4c2d3fa57d1d72d60fb1f0c2a0870d681f8d@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1205222116160.32649@chino.kir.corp.google.com>

Commit-ID:  183e4c2d3fa57d1d72d60fb1f0c2a0870d681f8d
Gitweb:     http://git.kernel.org/tip/183e4c2d3fa57d1d72d60fb1f0c2a0870d681f8d
Author:     David Rientjes <rientjes@google.com>
AuthorDate: Tue, 22 May 2012 21:17:56 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 23 May 2012 16:08:45 +0200

sched/numa: Allocate 'struct node_queue' on any node for offline nodes

'struct node_queue' must be allocated with NUMA_NO_NODE for nodes
that are not (yet) online, otherwise the page allocator has a
bad zonelist and results in an early crash.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David Rientjes <rientjes@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Lee Schermerhorn <lee.schermerhorn@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.00.1205222116160.32649@chino.kir.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/numa.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/numa.c b/kernel/sched/numa.c
index 8eb92f7..fdf737d 100644
--- a/kernel/sched/numa.c
+++ b/kernel/sched/numa.c
@@ -885,7 +885,8 @@ static __init int numa_init(void)
 
 	for_each_node(node) {
 		struct node_queue *nq = kmalloc_node(sizeof(*nq),
-				GFP_KERNEL | __GFP_ZERO, node);
+				GFP_KERNEL | __GFP_ZERO,
+				node_online(node) ? node : NUMA_NO_NODE);
 		BUG_ON(!nq);
 
 		spin_lock_init(&nq->lock);

  reply	other threads:[~2012-05-23 15:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  1:40 linux-next: PowerPC boot failures in next-20120521 Stephen Rothwell
2012-05-22  1:40 ` Stephen Rothwell
2012-05-22  1:53 ` David Rientjes
2012-05-22  1:53   ` David Rientjes
2012-05-22  3:03   ` Stephen Rothwell
2012-05-22  3:03     ` Stephen Rothwell
2012-05-22  3:25     ` Stephen Rothwell
2012-05-22  3:25       ` Stephen Rothwell
2012-05-23  4:17     ` [patch] sched, numa: Allocate node_queue on any node for offline nodes David Rientjes
2012-05-23  4:17       ` David Rientjes
2012-05-23 15:33       ` tip-bot for David Rientjes [this message]
2012-06-13 13:36       ` [tip:sched/numa] sched/numa: Allocate 'struct node_queue' " tip-bot for David Rientjes
2012-05-22  2:12 ` linux-next: PowerPC boot failures in next-20120521 Michael Neuling
2012-05-22  2:12   ` Michael Neuling
2012-05-22  2:25   ` David Rientjes
2012-05-22  2:25     ` David Rientjes
2012-05-22  2:39     ` Michael Neuling
2012-05-22  2:39       ` Michael Neuling
2012-05-22  2:40       ` Michael Neuling
2012-05-22  2:40         ` Michael Neuling
2012-05-22  2:44         ` David Rientjes
2012-05-22  2:44           ` David Rientjes
2012-05-22  2:51           ` Michael Neuling
2012-05-22  2:51             ` Michael Neuling
2012-05-22  2:58             ` David Rientjes
2012-05-22  2:58               ` David Rientjes
2012-05-22  3:12               ` Michael Neuling
2012-05-22  3:12                 ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-183e4c2d3fa57d1d72d60fb1f0c2a0870d681f8d@git.kernel.org \
    --to=rientjes@google.com \
    --cc=hpa@zytor.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.