From: tip-bot for Anna-Maria Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
anna-maria@linutronix.de, daniel.lezcano@linaro.org,
hpa@zytor.com, tglx@linutronix.de
Subject: [tip:timers/core] clocksource/drivers/time-armada-370-xp: Fix return value check
Date: Tue, 12 Jul 2016 08:40:01 -0700 [thread overview]
Message-ID: <tip-1d661bf5327a2c059ec967f850e89362e637f4e6@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1607121731020.1344@hypnos.tec.linutronix.de>
Commit-ID: 1d661bf5327a2c059ec967f850e89362e637f4e6
Gitweb: http://git.kernel.org/tip/1d661bf5327a2c059ec967f850e89362e637f4e6
Author: Anna-Maria Gleixner <anna-maria@linutronix.de>
AuthorDate: Tue, 12 Jul 2016 16:40:09 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 12 Jul 2016 17:33:22 +0200
clocksource/drivers/time-armada-370-xp: Fix return value check
The failure check of armada_370_xp_timer_setup() in
armada_370_xp_timer_common_init() is negated. This leads to an error message
and exit in case of a successful initialization. Remove the stray '!'.
Fixes: 12549e27c63c ("clocksource/drivers/time-armada-370-xp: Convert init function to return error")
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1607121731020.1344@hypnos.tec.linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/clocksource/time-armada-370-xp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
index a4e5923..20ec066 100644
--- a/drivers/clocksource/time-armada-370-xp.c
+++ b/drivers/clocksource/time-armada-370-xp.c
@@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_common_init(struct device_node *np)
}
res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
- if (!res) {
+ if (res) {
pr_err("Failed to setup timer");
return res;
}
next prev parent reply other threads:[~2016-07-12 15:40 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:59 [GIT PULL] clockevents for 4.8 Daniel Lezcano
2016-07-07 8:00 ` [PATCH 01/93] clocksource/drivers/armada-370-xp: Make syscore_ops static Daniel Lezcano
2016-07-07 8:00 ` [PATCH 02/93] clocksource/drivers/digicolor: Fix warning of non-static function Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 03/93] clocksource/drivers/samsung_pwm_timer: Fix endian accessors Daniel Lezcano
2016-07-07 8:00 ` [PATCH 04/93] clocksource/drivers/samsung_pwm: Fix typo in Kconfig Daniel Lezcano
[not found] ` <1467878526-1238-1-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-07-07 8:00 ` [PATCH 05/93] dt-bindings: Document rk3399 rk-timer bindings Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 06/93] clocksource/drivers/rockchip: Add the dynamic irq flag to the timer Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 07/93] clocksource/drivers/rockchip: Add support for the rk3399 SoC Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 10/93] dt-bindings: clocksource: Add Oxford Semiconductor RPS Timer bindings Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 13/93] clocksource/drivers/rockchip_timer: Convert init function to return error Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 14/93] clocksource/drivers/mtk_timer: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 08/93] arm64: dts: rockchip: Add rktimer device node for rk3399 Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 09/93] clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 11/93] of: Add a new macro to declare_of for one parameter function returning a value Daniel Lezcano
2016-07-07 8:00 ` [PATCH 12/93] clocksource/drivers/clksrc-probe: Introduce init functions with return code Daniel Lezcano
2016-07-07 8:00 ` [PATCH 15/93] clocksource/drivers/exynos_mct: Convert init function to return error Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 16/93] clocksource/drivers/asm9260: " Daniel Lezcano
2016-07-07 8:00 ` [PATCH 17/93] clocksource/drivers/cadence_ttc: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 18/93] clocksource/drivers/st_lpc: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 19/93] clocksource/drivers/dw_apb_timer: " Daniel Lezcano
2016-07-07 8:00 ` [PATCH 20/93] clocksource/drivers/clps711x: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 21/93] clocksource/drivers/digicolor: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 22/93] clocksource/drivers/armv7m_systick: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 23/93] clocksource/drivers/bcm2835_timer: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 24/93] clocksource/drivers/bcm_kona: " Daniel Lezcano
2016-07-07 8:00 ` [PATCH 25/93] clocksource/drivers/clksrc-dbx500: " Daniel Lezcano
2016-07-07 8:00 ` Daniel Lezcano
2016-07-07 8:00 ` [PATCH 26/93] clocksource/drivers/fsl_ftm_timer: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 27/93] clocksource/drivers/arm_arch_timer: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 28/93] clocksource/drivers/arm_global_timer: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 29/93] clocksource/drivers/h8300_timer16: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 30/93] clocksource/drivers/h8300_timer8: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 31/93] clocksource/drivers/h8300_tpu: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 32/93] clocksource/drivers/meson6_timer.c: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 33/93] clocksource/drivers/mips-gic-timer: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 34/93] clocksource/drivers/moxart: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 35/93] clocksource/drivers/mps2-timer: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 36/93] clocksource/drivers/mxs: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 37/93] clocksource/drivers/nomadik-mtu: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 38/93] clocksource/drivers/pxa: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 39/93] clocksource/drivers/qcom: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 40/93] clocksource/drivers/samsung_pwm: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 41/93] clocksource/drivers/sun4i: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 42/93] clocksource/drivers/tango_xtal: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 43/93] clocksource/drivers/tegra20: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 44/93] clocksource/drivers/time-armada-370-xp: " Daniel Lezcano
2016-07-12 15:11 ` Anna-Maria Gleixner
2016-07-12 15:18 ` Thomas Gleixner
2016-07-12 15:33 ` Anna-Maria Gleixner
2016-07-12 15:40 ` tip-bot for Anna-Maria Gleixner [this message]
2016-07-07 8:01 ` [PATCH 45/93] clocksource/drivers/time-efm32: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 46/93] clocksource/drivers/time-lpc32xx: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 47/93] clocksource/drivers/orion: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 48/93] clocksource/drivers/pistachio: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 49/93] clocksource/drivers/atlas7: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 50/93] clocksource/drivers/atmel-pit: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 51/93] clocksource/drivers/atmel-st: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 52/93] clocksource/drivers/prima2: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 53/93] clocksource/drivers/imx-gpt: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 54/93] clocksource/drivers/integrator-ap: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 55/93] clocksource/drivers/keystone: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 56/93] clocksource/drivers/sp804: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 57/93] clocksource/drivers/stm32: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 58/93] clocksource/drivers/sun5i: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 59/93] clocksource/drivers/ti-32k: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 60/93] clocksource/drivers/u300: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 61/93] clocksource/drivers/versatile: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 62/93] clocksource/drivers/vf_pit_timer: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 63/93] clocksource/drivers/vt8500: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 64/93] clocksource/drivers/zevio: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 65/93] clocksource/drivers/microblaze: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 66/93] clocksource/drivers/ralink: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 67/93] clocksource/drivers/nios2: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 68/93] clocksource/drivers/smp_twd: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 69/93] clocksource/drivers/nps: " Daniel Lezcano
2016-07-07 8:01 ` [PATCH 70/93] clocksource/drivers/arc: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 71/93] clocksource/drivers/oxnas-rps: " Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 72/93] clocksources: Switch back to the clksrc table Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` Daniel Lezcano
2016-07-07 8:01 ` [PATCH 73/93] clk: Add missing clk_get_sys() stub Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1d661bf5327a2c059ec967f850e89362e637f4e6@git.kernel.org \
--to=tipbot@zytor.com \
--cc=anna-maria@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.