All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Oleg Nesterov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	torvalds@linux-foundation.org, seto.hidetoshi@jp.fujitsu.com,
	peterz@infradead.org, umgwanakikbuti@gmail.com, riel@redhat.com,
	fmayhar@google.com, akpm@linux-foundation.org, srao@redhat.com,
	fweisbec@redhat.com, tglx@linutronix.de, oleg@redhat.com,
	lwoodman@redhat.com
Subject: [tip:sched/core] sched: Change thread_group_cputime() to use for_each_thread()
Date: Wed, 20 Aug 2014 01:19:21 -0700	[thread overview]
Message-ID: <tip-1e4dda08b4c39b3d8f4a3ee7269d49e0200c8af8@git.kernel.org> (raw)
In-Reply-To: <20140813192000.GA19327@redhat.com>

Commit-ID:  1e4dda08b4c39b3d8f4a3ee7269d49e0200c8af8
Gitweb:     http://git.kernel.org/tip/1e4dda08b4c39b3d8f4a3ee7269d49e0200c8af8
Author:     Oleg Nesterov <oleg@redhat.com>
AuthorDate: Wed, 13 Aug 2014 21:20:00 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 20 Aug 2014 09:47:18 +0200

sched: Change thread_group_cputime() to use for_each_thread()

Change thread_group_cputime() to use for_each_thread() instead of
buggy while_each_thread(). This also makes the pid_alive() check
unnecessary.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Frank Mayhar <fmayhar@google.com>
Cc: Frederic Weisbecker <fweisbec@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Sanjay Rao <srao@redhat.com>
Cc: Larry Woodman <lwoodman@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140813192000.GA19327@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/cputime.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 72fdf06..3e52836 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -294,18 +294,12 @@ void thread_group_cputime(struct task_struct *tsk, struct task_cputime *times)
 	times->sum_exec_runtime = sig->sum_sched_runtime;
 
 	rcu_read_lock();
-	/* make sure we can trust tsk->thread_group list */
-	if (!likely(pid_alive(tsk)))
-		goto out;
-
-	t = tsk;
-	do {
+	for_each_thread(tsk, t) {
 		task_cputime(t, &utime, &stime);
 		times->utime += utime;
 		times->stime += stime;
 		times->sum_exec_runtime += task_sched_runtime(t);
-	} while_each_thread(tsk, t);
-out:
+	}
 	rcu_read_unlock();
 }
 

  reply	other threads:[~2014-08-20  8:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 19:19 [PATCH 0/4] sched: don't use while_each_thread() Oleg Nesterov
2014-08-13 19:19 ` [PATCH 1/4] sched: s/do_each_thread/for_each_process_thread/ in core.c Oleg Nesterov
2014-08-20  8:18   ` [tip:sched/core] " tip-bot for Oleg Nesterov
2014-08-13 19:19 ` [PATCH 2/4] sched: s/do_each_thread/for_each_process_thread/ in debug.c Oleg Nesterov
2014-08-20  8:19   ` [tip:sched/core] " tip-bot for Oleg Nesterov
2014-08-13 19:20 ` [PATCH 3/4] sched: change thread_group_cputime() to use for_each_thread() Oleg Nesterov
2014-08-20  8:19   ` tip-bot for Oleg Nesterov [this message]
2014-08-13 19:20 ` [PATCH 4/4] sched: change autogroup_move_group() " Oleg Nesterov
2014-08-20  8:19   ` [tip:sched/core] sched: Change " tip-bot for Oleg Nesterov
2014-08-13 19:23 ` [PATCH 0/4] sched: don't use while_each_thread() Peter Zijlstra
2014-08-17 15:25 ` [PATCH 0/2] sched: tasklist_lock cleanups (Was: don't use while_each_thread()) Oleg Nesterov
2014-08-17 15:26   ` [PATCH 1/2] sched: normalize_rt_tasks: don't use _irqsave for tasklist_lock, use task_rq_lock() Oleg Nesterov
2014-08-17 15:26   ` [PATCH 2/2] sched: print_rq: don't use tasklist_lock Oleg Nesterov
2014-08-17 21:14   ` [PATCH 0/2] sched: tasklist_lock cleanups (Was: don't use while_each_thread()) Kirill Tkhai
2014-08-18 15:09     ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1e4dda08b4c39b3d8f4a3ee7269d49e0200c8af8@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=fmayhar@google.com \
    --cc=fweisbec@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lwoodman@redhat.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=srao@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.