From: tip-bot for Fenghua Yu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, h.peter.anvin@intel.com,
ravi.v.shankar@intel.com, tony.luck@intel.com,
sai.praneeth.prakhya@intel.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, hpa@zytor.com,
fenghua.yu@intel.com, vikas.shivappa@linux.intel.com
Subject: [tip:x86/cache] x86/intel_rdt: Fix setting of closid when adding CPUs to a group
Date: Mon, 28 Nov 2016 02:16:50 -0800 [thread overview]
Message-ID: <tip-2659f46da8307871989f475accdcdfc4807e9e6c@git.kernel.org> (raw)
In-Reply-To: <1479511084-59727-1-git-send-email-fenghua.yu@intel.com>
Commit-ID: 2659f46da8307871989f475accdcdfc4807e9e6c
Gitweb: http://git.kernel.org/tip/2659f46da8307871989f475accdcdfc4807e9e6c
Author: Fenghua Yu <fenghua.yu@intel.com>
AuthorDate: Fri, 18 Nov 2016 15:18:03 -0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 28 Nov 2016 11:07:50 +0100
x86/intel_rdt: Fix setting of closid when adding CPUs to a group
There was a cut & paste error when adding code to update the per-cpu
closid when changing the bitmask of CPUs to an rdt group.
The update erronously assigns the closid of the default group to the CPUs
which are moved to a group instead of assigning the closid of their new
group. Use the proper closid.
Fixes: f410770293a1 ("x86/intel_rdt: Update percpu closid immeditately on CPUs affected by change")
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Cc: "Ravi V Shankar" <ravi.v.shankar@intel.com>
Cc: "Tony Luck" <tony.luck@intel.com>
Cc: "Sai Prakhya" <sai.praneeth.prakhya@intel.com>
Cc: "Vikas Shivappa" <vikas.shivappa@linux.intel.com>
Cc: "H. Peter Anvin" <h.peter.anvin@intel.com>
Link: http://lkml.kernel.org/r/1479511084-59727-1-git-send-email-fenghua.yu@intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index 98edba4..eccea8a 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -278,7 +278,7 @@ static ssize_t rdtgroup_cpus_write(struct kernfs_open_file *of,
continue;
cpumask_andnot(&r->cpu_mask, &r->cpu_mask, tmpmask);
}
- rdt_update_percpu_closid(tmpmask, rdtgroup_default.closid);
+ rdt_update_percpu_closid(tmpmask, rdtgrp->closid);
}
/* Done pushing/pulling - update this group with new mask */
prev parent reply other threads:[~2016-11-28 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 23:18 [PATCH 1/2] x86/intel_rdt: Fix setting of closid when adding CPUs to a group Fenghua Yu
2016-11-18 23:18 ` [PATCH 2/2] x86/intel_rdt: Update task closid immediately on CPU in rmdir and unmount Fenghua Yu
2016-11-23 14:23 ` Thomas Gleixner
2016-11-26 2:36 ` Fenghua Yu
2016-11-26 9:08 ` Thomas Gleixner
2016-11-26 21:06 ` Fenghua Yu
2016-11-28 10:17 ` [tip:x86/cache] " tip-bot for Fenghua Yu
2016-11-28 10:16 ` tip-bot for Fenghua Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-2659f46da8307871989f475accdcdfc4807e9e6c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=fenghua.yu@intel.com \
--cc=h.peter.anvin@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.