All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
	hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
	namhyung.kim@lge.com, namhyung@kernel.org, jolsa@redhat.com,
	fweisbec@gmail.com, rostedt@goodmis.org, dsahern@gmail.com,
	tglx@linutronix.de
Subject: [tip:perf/core] perf util: Skip reading header_event file
Date: Fri, 19 Jul 2013 00:47:02 -0700	[thread overview]
Message-ID: <tip-2b2efc7fb8a3ede936580e870c5f809e491c925c@git.kernel.org> (raw)
In-Reply-To: <1370323231-14022-11-git-send-email-namhyung@kernel.org>

Commit-ID:  2b2efc7fb8a3ede936580e870c5f809e491c925c
Gitweb:     http://git.kernel.org/tip/2b2efc7fb8a3ede936580e870c5f809e491c925c
Author:     Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Tue, 4 Jun 2013 14:20:25 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 12 Jul 2013 13:52:23 -0300

perf util: Skip reading header_event file

It seems perf does not parse header_event file so we can skip it as we
do for header_page file.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1370323231-14022-11-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/trace-event-read.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
index 0dd9fbd..fa45fca 100644
--- a/tools/perf/util/trace-event-read.c
+++ b/tools/perf/util/trace-event-read.c
@@ -212,7 +212,6 @@ static int read_ftrace_printk(struct pevent *pevent)
 static int read_header_files(struct pevent *pevent)
 {
 	unsigned long long size;
-	char *header_event;
 	char buf[BUFSIZ];
 	int ret = 0;
 
@@ -236,14 +235,8 @@ static int read_header_files(struct pevent *pevent)
 	}
 
 	size = read8(pevent);
-	header_event = malloc(size);
-	if (header_event == NULL)
-		return -1;
-
-	if (do_read(header_event, size) < 0)
-		ret = -1;
+	skip(size);
 
-	free(header_event);
 	return ret;
 }
 

  reply	other threads:[~2013-07-19  7:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  5:20 [PATCHSET 00/16] perf tools: Cleanups on tracepoint handling Namhyung Kim
2013-06-04  5:20 ` [PATCH 01/16] tools lib traceevent: Remove unused install targets Namhyung Kim
2013-07-19  7:45   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 02/16] tools lib traceevent: Get rid of unused gui target Namhyung Kim
2013-07-19  7:45   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 03/16] tools lib traceevent: Add const qualifier to string arguments Namhyung Kim
2013-07-19  7:45   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 04/16] tools lib traceevent: Add trace_seq_reset() Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 05/16] tools lib traceevent: Add page_size field to pevent Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 06/16] tools lib traceevent: Port kbuffer parser routines Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 07/16] perf util: Save page size in a trace file to pevent Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 08/16] perf util: Save long size of traced system Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 09/16] perf util: Make file/host_bigendian variable local Namhyung Kim
2013-07-19  7:46   ` [tip:perf/core] perf util: Make file/ host_bigendian " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 10/16] perf util: Skip reading header_event file Namhyung Kim
2013-07-19  7:47   ` tip-bot for Namhyung Kim [this message]
2013-06-04  5:20 ` [PATCH 11/16] perf util: Parse header_page to get proper long size Namhyung Kim
2013-06-06 15:37   ` Jiri Olsa
2013-06-07  8:56     ` Namhyung Kim
2013-06-07  9:01       ` Jiri Olsa
2013-07-19  7:47   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 12/16] perf util: Get rid of unused header_page_* variables Namhyung Kim
2013-07-19  7:47   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 13/16] perf util: Move latency_format variable to builtin-script.c Namhyung Kim
2013-07-19  7:47   ` [tip:perf/core] perf script: Adopt latency_format variable tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 14/16] perf util: Rename read_*() functions in trace-event-info.c Namhyung Kim
2013-07-19  7:47   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 15/16] perf util: No need to call read_trace_init() in tracing_data_header() Namhyung Kim
2013-07-19  7:47   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-04  5:20 ` [PATCH 16/16] perf util: Remove unused enum and macro in trace-event.h Namhyung Kim
2013-07-19  7:47   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-24  5:38 ` [PATCHSET 00/16] perf tools: Cleanups on tracepoint handling Namhyung Kim
2013-07-04  8:39 ` Namhyung Kim
2013-07-05 13:16   ` Arnaldo Carvalho de Melo
2013-07-05 13:35     ` Namhyung Kim
2013-07-05 14:57 ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-2b2efc7fb8a3ede936580e870c5f809e491c925c@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.