From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920AbbJHJrU (ORCPT ); Thu, 8 Oct 2015 05:47:20 -0400 Received: from terminus.zytor.com ([198.137.202.10]:45918 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754787AbbJHJrS (ORCPT ); Thu, 8 Oct 2015 05:47:18 -0400 Date: Thu, 8 Oct 2015 02:46:59 -0700 From: tip-bot for Andrzej Hajda Message-ID: Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, b.zolnierkie@samsung.com, hpa@zytor.com, m.szyprowski@samsung.com, acme@redhat.com, tglx@linutronix.de, a.p.zijlstra@chello.nl, a.hajda@samsung.com Reply-To: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, acme@redhat.com, tglx@linutronix.de, a.hajda@samsung.com, a.p.zijlstra@chello.nl In-Reply-To: <1444122017-16856-1-git-send-email-a.hajda@samsung.com> References: <1444122017-16856-1-git-send-email-a.hajda@samsung.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Fix handling read result using a signed variable Git-Commit-ID: 38349665388fb079fb2bc8c46db9446dd976802a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 38349665388fb079fb2bc8c46db9446dd976802a Gitweb: http://git.kernel.org/tip/38349665388fb079fb2bc8c46db9446dd976802a Author: Andrzej Hajda AuthorDate: Tue, 6 Oct 2015 11:00:17 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 6 Oct 2015 18:04:59 -0300 perf tools: Fix handling read result using a signed variable The function can return negative value, assigning it to unsigned variable can cause memory corruption. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Cc: Bartlomiej Zolnierkiewicz Cc: Marek Szyprowski Cc: Peter Zijlstra Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/1444122017-16856-1-git-send-email-a.hajda@samsung.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/event.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index cb98b5a..8b10621 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c @@ -67,7 +67,8 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len, char filename[PATH_MAX]; char bf[4096]; int fd; - size_t size = 0, n; + size_t size = 0; + ssize_t n; char *nl, *name, *tgids, *ppids; *tgid = -1;