From: tip-bot for Taeung Song <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, jolsa@redhat.com, milian.wolff@kdab.com,
hpa@zytor.com, mingo@kernel.org, acme@redhat.com,
tglx@linutronix.de, treeze.taeung@gmail.com,
linux-kernel@vger.kernel.org
Subject: [tip:perf/core] perf annotate stdio: Fix column header when using --show-total-period
Date: Wed, 26 Jul 2017 10:27:15 -0700 [thread overview]
Message-ID: <tip-38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73@git.kernel.org> (raw)
In-Reply-To: <c3c902e7-95bc-16d4-366f-12eb034c5c8d@gmail.com>
Commit-ID: 38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73
Gitweb: http://git.kernel.org/tip/38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Tue, 25 Jul 2017 06:28:42 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 25 Jul 2017 22:46:37 -0300
perf annotate stdio: Fix column header when using --show-total-period
Currently the first column header is always "Percent", fix it to show
correct column name based on given options, i.e. if using
--show-total-period, show "Event count" as a first column.
Reported-by: Milian Wolff <milian.wolff@kdab.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/c3c902e7-95bc-16d4-366f-12eb034c5c8d@gmail.com
[ Extracted from a larger patch ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 004072f..c2b4b00 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1824,7 +1824,8 @@ int symbol__annotate_printf(struct symbol *sym, struct map *map,
width *= evsel->nr_members;
graph_dotted_len = printf(" %-*.*s| Source code & Disassembly of %s for %s (%" PRIu64 " samples)\n",
- width, width, "Percent", d_filename, evsel_name, h->nr_samples);
+ width, width, symbol_conf.show_total_period ? "Event count" : "Percent",
+ d_filename, evsel_name, h->nr_samples);
printf("%-*.*s----\n",
graph_dotted_len, graph_dotted_len, graph_dotted_line);
next prev parent reply other threads:[~2017-07-26 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 21:36 [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period option showing number of samples Taeung Song
2017-07-20 19:19 ` Arnaldo Carvalho de Melo
2017-07-21 9:41 ` Taeung Song
2017-07-21 11:24 ` Arnaldo Carvalho de Melo
2017-07-24 1:51 ` Taeung Song
2017-07-24 17:37 ` Arnaldo Carvalho de Melo
2017-07-24 21:28 ` Taeung Song
2017-07-25 14:42 ` Arnaldo Carvalho de Melo
2017-07-25 15:53 ` Taeung Song
2017-07-25 16:17 ` Arnaldo Carvalho de Melo
2017-07-26 11:57 ` Taeung Song
2017-07-26 20:17 ` Arnaldo Carvalho de Melo
2017-07-27 15:14 ` Taeung Song
2017-07-26 17:27 ` tip-bot for Taeung Song [this message]
2017-07-21 14:47 ` Arnaldo Carvalho de Melo
2017-07-22 22:46 ` Namhyung Kim
2017-07-23 15:46 ` Andi Kleen
2017-07-24 17:34 ` Arnaldo Carvalho de Melo
2017-07-24 17:46 ` Andi Kleen
2017-07-24 18:07 ` Arnaldo Carvalho de Melo
2017-07-26 17:20 ` [tip:perf/core] perf hists: Pass perf_sample to __symbol__inc_addr_samples() tip-bot for Taeung Song
2017-07-26 17:20 ` [tip:perf/core] perf annotate: Store the sample period in each histogram bucket tip-bot for Taeung Song
2017-07-26 17:20 ` [tip:perf/core] perf annotate: Do not overwrite sample->period tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-38d2dcd0ccf85b55d783edbfc14fd8dea4d55b73@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.