From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbdJEL1K (ORCPT ); Thu, 5 Oct 2017 07:27:10 -0400 Received: from terminus.zytor.com ([65.50.211.136]:54753 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdJEL1I (ORCPT ); Thu, 5 Oct 2017 07:27:08 -0400 Date: Thu, 5 Oct 2017 04:26:01 -0700 From: tip-bot for Jithu Joseph Message-ID: Cc: jithu.joseph@intel.com, fenghua.yu@intel.com, tglx@linutronix.de, hpa@zytor.com, reinette.chatre@intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org Reply-To: reinette.chatre@intel.com, linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, jithu.joseph@intel.com, fenghua.yu@intel.com, hpa@zytor.com In-Reply-To: <1507157337-18118-1-git-send-email-jithu.joseph@intel.com> References: <1507157337-18118-1-git-send-email-jithu.joseph@intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/cache] x86/intel_rdt: Remove redundant assignment Git-Commit-ID: 3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c Gitweb: https://git.kernel.org/tip/3916a4135c696fa226a1abe6d6a0ff7f5edd9a7c Author: Jithu Joseph AuthorDate: Wed, 4 Oct 2017 15:48:57 -0700 Committer: Thomas Gleixner CommitDate: Thu, 5 Oct 2017 13:20:32 +0200 x86/intel_rdt: Remove redundant assignment The assignment to the 'files' variable is immediately overwritten in the following line. Remove the older assignment, which was meant specifially for creating control groups files. Fixes: c7d9aac61311 ("x86/intel_rdt/cqm: Add mkdir support for RDT monitoring") Reported-by: Reinette Chatre Signed-off-by: Jithu Joseph Signed-off-by: Thomas Gleixner Acked-by: Fenghua Yu Cc: tony.luck@intel.com Cc: vikas.shivappa@intel.com Link: https://lkml.kernel.org/r/1507157337-18118-1-git-send-email-jithu.joseph@intel.com --- arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c index abd220b..8a61b20 100644 --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c @@ -1635,7 +1635,6 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn, goto out_destroy; } - files = RFTYPE_BASE | RFTYPE_CTRL; files = RFTYPE_BASE | BIT(RF_CTRLSHIFT + rtype); ret = rdtgroup_add_files(kn, files); if (ret) {