From: tip-bot for Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
mathieu.desnoyers@efficios.com, rusty@rustcorp.com.au,
ananth@in.ibm.com, masami.hiramatsu.pt@hitachi.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/core] x86: Use __stop_machine() in text_poke_smp()
Date: Thu, 14 Oct 2010 07:41:06 GMT [thread overview]
Message-ID: <tip-3caa37519ccbb200c7fbbf6ff4fb306a30f29425@git.kernel.org> (raw)
In-Reply-To: <20101014031036.4100.83989.stgit@ltc236.sdl.hitachi.co.jp>
Commit-ID: 3caa37519ccbb200c7fbbf6ff4fb306a30f29425
Gitweb: http://git.kernel.org/tip/3caa37519ccbb200c7fbbf6ff4fb306a30f29425
Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Thu, 14 Oct 2010 12:10:36 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 14 Oct 2010 08:55:28 +0200
x86: Use __stop_machine() in text_poke_smp()
Use __stop_machine() in text_poke_smp() because the caller
must get online_cpus before calling text_poke_smp(), but
stop_machine() do it again. We don't need it.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: 2nddept-manager@sdl.hitachi.co.jp
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
LKML-Reference: <20101014031036.4100.83989.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/alternative.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index cb0e6d3..a36bb90 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -637,7 +637,8 @@ void *__kprobes text_poke_smp(void *addr, const void *opcode, size_t len)
tpp.len = len;
atomic_set(&stop_machine_first, 1);
wrote_text = 0;
- stop_machine(stop_machine_text_poke, (void *)&tpp, NULL);
+ /* Use __stop_machine() because the caller already got online_cpus. */
+ __stop_machine(stop_machine_text_poke, (void *)&tpp, NULL);
return addr;
}
next prev parent reply other threads:[~2010-10-14 7:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 3:10 [PATCH -tip 0/5] Kprobes updates Masami Hiramatsu
2010-10-14 3:10 ` [PATCH -tip 1/5] [RESEND] kprobes: Update document about irq disabled state in kprobe handler Masami Hiramatsu
2010-10-14 7:39 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-10-14 3:10 ` [PATCH -tip 2/5] [RESEND][BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes Masami Hiramatsu
2010-10-14 7:40 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-10-14 3:10 ` [PATCH -tip 3/5] Define __stop_machine when CONFIG_STOP_MACHINE=n Masami Hiramatsu
2010-10-14 5:00 ` Tejun Heo
2010-10-14 7:40 ` [tip:perf/core] stopmachine: " tip-bot for Masami Hiramatsu
2010-10-14 3:10 ` [PATCH -tip 4/5] [BUGFIX] x86: Use __stop_machine() in text_poke_smp() Masami Hiramatsu
2010-10-14 7:41 ` tip-bot for Masami Hiramatsu [this message]
2010-10-14 3:10 ` [PATCH -tip 5/5] [BUGFIX] kconfig/x86: Add HAVE_TEXT_POKE_SMP config for stop_machine dependency Masami Hiramatsu
2010-10-14 7:41 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-10-14 6:52 ` [PATCH -tip 0/5] Kprobes updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3caa37519ccbb200c7fbbf6ff4fb306a30f29425@git.kernel.org \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.