All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Rik van Riel <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	peterz@infradead.org, gang.xing@hp.com, riel@redhat.com,
	aarcange@redhat.com, chegu_vinod@hp.com, tglx@linutronix.de
Subject: [tip:sched/urgent] sched,numa: add cond_resched to task_numa_work
Date: Fri, 21 Feb 2014 12:32:14 -0800	[thread overview]
Message-ID: <tip-3cf1962cdbf6b3a9e3ef21116d215bbab350ea37@git.kernel.org> (raw)
In-Reply-To: <1392761566-24834-2-git-send-email-riel@redhat.com>

Commit-ID:  3cf1962cdbf6b3a9e3ef21116d215bbab350ea37
Gitweb:     http://git.kernel.org/tip/3cf1962cdbf6b3a9e3ef21116d215bbab350ea37
Author:     Rik van Riel <riel@redhat.com>
AuthorDate: Tue, 18 Feb 2014 17:12:44 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 21 Feb 2014 21:27:10 +0100

sched,numa: add cond_resched to task_numa_work

Normally task_numa_work scans over a fairly small amount of memory,
but it is possible to run into a large unpopulated part of virtual
memory, with no pages mapped. In that case, task_numa_work can run
for a while, and it may make sense to reschedule as required.

Cc: akpm@linux-foundation.org
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Rik van Riel <riel@redhat.com>
Reported-by: Xing Gang <gang.xing@hp.com>
Tested-by: Chegu Vinod <chegu_vinod@hp.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1392761566-24834-2-git-send-email-riel@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 966cc2b..7815709 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1757,6 +1757,8 @@ void task_numa_work(struct callback_head *work)
 			start = end;
 			if (pages <= 0)
 				goto out;
+
+			cond_resched();
 		} while (end != vma->vm_end);
 	}
 

  reply	other threads:[~2014-02-21 20:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 22:12 [PATCH -mm 0/3] fix numa vs kvm scalability issue riel
2014-02-18 22:12 ` riel
2014-02-18 22:12 ` [PATCH -mm 1/3] sched,numa: add cond_resched to task_numa_work riel
2014-02-18 22:12   ` riel
2014-02-21 20:32   ` tip-bot for Rik van Riel [this message]
2014-02-18 22:12 ` [PATCH -mm 2/3] mm,numa: reorganize change_pmd_range riel
2014-02-18 22:12   ` riel
2014-02-19  2:22   ` David Rientjes
2014-02-19  2:22     ` David Rientjes
2014-02-18 22:12 ` [PATCH -mm 3/3] move mmu notifier call from change_protection to change_pmd_range riel
2014-02-18 22:12   ` riel
2014-02-19  2:24   ` David Rientjes
2014-02-19  2:24     ` David Rientjes
2014-02-19  3:08     ` Rik van Riel
2014-02-19  3:08       ` Rik van Riel
2014-02-19  3:18     ` [PATCH -mm v2 " Rik van Riel
2014-02-19  3:18       ` Rik van Riel
2014-02-19  8:59 ` [PATCH -mm 0/3] fix numa vs kvm scalability issue Peter Zijlstra
2014-02-19  8:59   ` Peter Zijlstra
2014-02-19 19:28   ` Andrew Morton
2014-02-19 19:28     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-3cf1962cdbf6b3a9e3ef21116d215bbab350ea37@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=aarcange@redhat.com \
    --cc=chegu_vinod@hp.com \
    --cc=gang.xing@hp.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.