From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760130AbcBYHsK (ORCPT ); Thu, 25 Feb 2016 02:48:10 -0500 Received: from torg.zytor.com ([198.137.202.12]:58000 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759510AbcBYHsG (ORCPT ); Thu, 25 Feb 2016 02:48:06 -0500 Date: Wed, 24 Feb 2016 23:47:05 -0800 From: tip-bot for Andy Lutomirski Message-ID: Cc: luto@kernel.org, bp@alien8.de, luto@amacapital.net, torvalds@linux-foundation.org, brgerst@gmail.com, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org Reply-To: luto@kernel.org, torvalds@linux-foundation.org, bp@alien8.de, luto@amacapital.net, mingo@kernel.org, tglx@linutronix.de, brgerst@gmail.com, peterz@infradead.org, dvlasenk@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/entry/compat: Add missing CLAC to entry_INT80_32 Git-Commit-ID: 3d44d51bd339766f0178f0cf2e8d048b4a4872aa X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3d44d51bd339766f0178f0cf2e8d048b4a4872aa Gitweb: http://git.kernel.org/tip/3d44d51bd339766f0178f0cf2e8d048b4a4872aa Author: Andy Lutomirski AuthorDate: Wed, 24 Feb 2016 12:18:49 -0800 Committer: Ingo Molnar CommitDate: Thu, 25 Feb 2016 08:31:20 +0100 x86/entry/compat: Add missing CLAC to entry_INT80_32 This doesn't seem to fix a regression -- I don't think the CLAC was ever there. I double-checked in a debugger: entries through the int80 gate do not automatically clear AC. Stable maintainers: I can provide a backport to 4.3 and earlier if needed. This needs to be backported all the way to 3.10. Reported-by: Brian Gerst Signed-off-by: Andy Lutomirski Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: # v3.10 and later Fixes: 63bcff2a307b ("x86, smap: Add STAC and CLAC instructions to control user space access") Link: http://lkml.kernel.org/r/b02b7e71ae54074be01fc171cbd4b72517055c0e.1456345086.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/entry/entry_64_compat.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S index ff1c6d6..3c990ee 100644 --- a/arch/x86/entry/entry_64_compat.S +++ b/arch/x86/entry/entry_64_compat.S @@ -261,6 +261,7 @@ ENTRY(entry_INT80_compat) * Interrupts are off on entry. */ PARAVIRT_ADJUST_EXCEPTION_FRAME + ASM_CLAC /* Do this early to minimize exposure */ SWAPGS /*