From: tip-bot for Rob Herring <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, magnus.damm@gmail.com,
horms@verge.net.au, robh@kernel.org, tglx@linutronix.de,
linux@arm.linux.org.uk, hpa@zytor.com, mingo@kernel.org
Subject: [tip:irq/urgent] sh: Kill off set_irq_flags usage
Date: Wed, 16 Sep 2015 13:58:27 -0700 [thread overview]
Message-ID: <tip-3e15135b98ecaa0228eb5dad42be7516cac38aa0@git.kernel.org> (raw)
In-Reply-To: <1440889285-5637-4-git-send-email-robh@kernel.org>
Commit-ID: 3e15135b98ecaa0228eb5dad42be7516cac38aa0
Gitweb: http://git.kernel.org/tip/3e15135b98ecaa0228eb5dad42be7516cac38aa0
Author: Rob Herring <robh@kernel.org>
AuthorDate: Sat, 29 Aug 2015 18:01:23 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 16 Sep 2015 16:53:39 +0200
sh: Kill off set_irq_flags usage
set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:
IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN
For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Simon Horman <horms@verge.net.au>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sh@vger.kernel.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Magnus Damm <magnus.damm@gmail.com>
Link: http://lkml.kernel.org/r/1440889285-5637-4-git-send-email-robh@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/sh/intc/internals.h | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h
index 7dff08e..6ce7f0d 100644
--- a/drivers/sh/intc/internals.h
+++ b/drivers/sh/intc/internals.h
@@ -99,15 +99,7 @@ static inline struct intc_desc_int *get_intc_desc(unsigned int irq)
*/
static inline void activate_irq(int irq)
{
-#ifdef CONFIG_ARM
- /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
- * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
- */
- set_irq_flags(irq, IRQF_VALID);
-#else
- /* same effect on other architectures */
- irq_set_noprobe(irq);
-#endif
+ irq_modify_status(irq, IRQ_NOREQUEST, IRQ_NOPROBE);
}
static inline int intc_handle_int_cmp(const void *a, const void *b)
next prev parent reply other threads:[~2015-09-16 20:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 23:01 [PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage Rob Herring
2015-08-29 23:01 ` Rob Herring
2015-08-29 23:01 ` [RESEND PATCH v3 1/5] gpu/drm: " Rob Herring
2015-08-29 23:01 ` Rob Herring
2015-08-29 23:01 ` [RESEND PATCH v3 2/5] irqchip: " Rob Herring
2015-08-29 23:01 ` Rob Herring
2015-09-16 20:58 ` [tip:irq/urgent] irqchip: Kill " tip-bot for Rob Herring
2015-08-29 23:01 ` [RESEND PATCH v3 3/5] sh: kill " Rob Herring
2015-08-29 23:01 ` Rob Herring
2015-08-31 5:01 ` Simon Horman
2015-08-31 5:01 ` Simon Horman
2015-08-31 12:52 ` Rob Herring
2015-08-31 12:52 ` Rob Herring
2015-09-01 1:09 ` Simon Horman
2015-09-01 1:09 ` Simon Horman
2015-09-16 20:58 ` tip-bot for Rob Herring [this message]
2015-08-29 23:01 ` [RESEND PATCH v3 4/5] ARM: remove ununsed set_irq_flags Rob Herring
2015-08-29 23:01 ` [RESEND PATCH v3 5/5] arm64: " Rob Herring
2015-08-31 14:13 ` [PATCH v3 RESEND 0/5] Remaining part of kill off set_irq_flags usage Thomas Gleixner
2015-08-31 14:13 ` Thomas Gleixner
2015-09-16 14:12 ` Rob Herring
2015-09-16 14:12 ` Rob Herring
2015-09-16 14:15 ` Thomas Gleixner
2015-09-16 14:15 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3e15135b98ecaa0228eb5dad42be7516cac38aa0@git.kernel.org \
--to=tipbot@zytor.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mingo@kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.