All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Xunlei Pang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: rostedt@goodmis.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, mingo@kernel.org,
	juri.lelli@gmail.com, pang.xunlei@linaro.org,
	peterz@infradead.org, efault@gmx.de, hpa@zytor.com,
	torvalds@linux-foundation.org
Subject: [tip:sched/core] sched/deadline: Remove a redundant condition from task_woken_dl()
Date: Mon, 3 Aug 2015 10:05:59 -0700	[thread overview]
Message-ID: <tip-3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd@git.kernel.org> (raw)
In-Reply-To: <1435995563-3723-2-git-send-email-xlpang@126.com>

Commit-ID:  3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd
Gitweb:     http://git.kernel.org/tip/3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd
Author:     Xunlei Pang <pang.xunlei@linaro.org>
AuthorDate: Sat, 4 Jul 2015 15:39:23 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 3 Aug 2015 12:21:20 +0200

sched/deadline: Remove a redundant condition from task_woken_dl()

'p' has been already queued at this point, so "!task_running(rq, p)"
and "p->nr_cpus_allowed > 1" imply that "has_pushable_dl_tasks(rq)"
is true, so it can be removed.

Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Juri Lelli <juri.lelli@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1435995563-3723-2-git-send-email-xlpang@126.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 0a17af35..20772ee 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1657,7 +1657,6 @@ static void task_woken_dl(struct rq *rq, struct task_struct *p)
 {
 	if (!task_running(rq, p) &&
 	    !test_tsk_need_resched(rq->curr) &&
-	    has_pushable_dl_tasks(rq) &&
 	    p->nr_cpus_allowed > 1 &&
 	    dl_task(rq->curr) &&
 	    (rq->curr->nr_cpus_allowed < 2 ||

  parent reply	other threads:[~2015-08-03 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1435995563-3723-1-git-send-email-xlpang@126.com>
2015-07-06 19:19 ` [PATCH 1/2] sched/rt: Remove a redundant condition from task_woken_rt() Steven Rostedt
     [not found] ` <1435995563-3723-2-git-send-email-xlpang@126.com>
2015-07-06 19:21   ` [PATCH 2/2] sched/deadline: Remove a redundant condition from task_woken_dl() Steven Rostedt
2015-08-03 17:05   ` tip-bot for Xunlei Pang [this message]
2015-08-03 17:05 ` [tip:sched/core] sched/rt: Remove a redundant condition from task_woken_rt() tip-bot for Xunlei Pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=juri.lelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.