All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	avorontsov@ru.mvista.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:tracing/ftrace] tracing: Fix TRACING_SUPPORT dependency for PPC32
Date: Mon, 23 Mar 2009 22:24:28 GMT	[thread overview]
Message-ID: <tip-45b9560895b07a4a09d55d49235c984db512c5aa@git.kernel.org> (raw)
In-Reply-To: <20090323220724.GA9851@oksana.dev.rtsoft.ru>

Commit-ID:  45b9560895b07a4a09d55d49235c984db512c5aa
Gitweb:     http://git.kernel.org/tip/45b9560895b07a4a09d55d49235c984db512c5aa
Author:     Anton Vorontsov <avorontsov@ru.mvista.com>
AuthorDate: Tue, 24 Mar 2009 01:07:24 +0300
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 23 Mar 2009 23:23:03 +0100

tracing: Fix TRACING_SUPPORT dependency for PPC32

commit 40ada30f9621fbd831ac2437b9a2a399aa ("tracing: clean up menu"),
despite the "clean up" in its purpose, introduced a behavioural
change for Kconfig symbols: we no longer able to select tracing
support on PPC32 (because IRQFLAGS_SUPPORT isn't yet implemented).

The IRQFLAGS_SUPPORT is not mandatory for most tracers, tracing core
has a special case for platforms w/o irqflags (which, by the way, has
become useless as of the commit above).

Though according to Ingo Molnar, there was periodic build failures on
weird, unmaintained architectures that had no irqflags-tracing support
and hence didn't know the raw_irqs_save/restore primitives. Thus we'd
better not enable irqflags-less tracing for all architectures.

This patch restores the old behaviour for PPC32, and thus brings the
tracing back. Other architectures can either add themselves to the
exception list or (better) implement TRACE_IRQFLAGS_SUPPORT.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-b: Steven Rostedt <rostedt@goodmis.org>
Cc: linuxppc-dev@ozlabs.org
LKML-Reference: <20090323220724.GA9851@oksana.dev.rtsoft.ru>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 kernel/trace/Kconfig |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index b0a46f8..8a4d729 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -63,7 +63,11 @@ config TRACING
 #
 config TRACING_SUPPORT
 	bool
-	depends on TRACE_IRQFLAGS_SUPPORT
+	# PPC32 has no irqflags tracing support, but it can use most of the
+	# tracers anyway, they were tested to build and work. Note that new
+	# exceptions to this list aren't welcomed, better implement the
+	# irqflags tracing for your architecture.
+	depends on TRACE_IRQFLAGS_SUPPORT || PPC32
 	depends on STACKTRACE_SUPPORT
 	default y
 

  reply	other threads:[~2009-03-23 22:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20 15:09 [PATCH] tracing: Fix TRACING_SUPPORT dependency Anton Vorontsov
2009-03-20 19:04 ` Ingo Molnar
2009-03-20 19:04   ` Ingo Molnar
2009-03-20 19:39   ` Anton Vorontsov
2009-03-20 19:39     ` Anton Vorontsov
2009-03-20 19:57     ` Ingo Molnar
2009-03-20 19:57       ` Ingo Molnar
2009-03-20 20:22       ` Anton Vorontsov
2009-03-20 20:22         ` Anton Vorontsov
2009-03-21 16:18         ` Ingo Molnar
2009-03-21 16:18           ` Ingo Molnar
2009-03-21 16:31           ` Steven Rostedt
2009-03-21 16:31             ` Steven Rostedt
2009-03-21 16:33             ` Ingo Molnar
2009-03-21 16:33               ` Ingo Molnar
2009-03-21 16:41               ` Steven Rostedt
2009-03-21 16:41                 ` Steven Rostedt
2009-03-21 16:43                 ` Steven Rostedt
2009-03-21 16:43                   ` Steven Rostedt
2009-03-21 16:46                   ` Ingo Molnar
2009-03-21 16:46                     ` Ingo Molnar
2009-03-23 22:07           ` [PATCH] tracing: Fix TRACING_SUPPORT dependency for PPC32 Anton Vorontsov
2009-03-23 22:07             ` Anton Vorontsov
2009-03-23 22:24             ` Anton Vorontsov [this message]
2009-03-24  0:51             ` Steven Rostedt
2009-03-24  0:51               ` Steven Rostedt
2009-03-24  5:43         ` [PATCH] tracing: Fix TRACING_SUPPORT dependency Benjamin Herrenschmidt
2009-03-24  5:43           ` Benjamin Herrenschmidt
2009-03-21  3:09       ` Steven Rostedt
2009-03-21  3:09         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-45b9560895b07a4a09d55d49235c984db512c5aa@git.kernel.org \
    --to=avorontsov@ru.mvista.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.