All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Geert Uytterhoeven <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, geert+renesas@glider.be,
	horms+renesas@verge.net.au, jason@lakedaemon.net,
	mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip:irq/core] irqchip: renesas: intc-irqpin: Improve binding documentation
Date: Mon, 8 Jun 2015 00:57:44 -0700	[thread overview]
Message-ID: <tip-496c28b13eb9d4f9c751b672daad8b110084cfd8@git.kernel.org> (raw)
In-Reply-To: <1432891663-23641-1-git-send-email-geert+renesas@glider.be>

Commit-ID:  496c28b13eb9d4f9c751b672daad8b110084cfd8
Gitweb:     http://git.kernel.org/tip/496c28b13eb9d4f9c751b672daad8b110084cfd8
Author:     Geert Uytterhoeven <geert+renesas@glider.be>
AuthorDate: Fri, 29 May 2015 11:27:43 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 5 Jun 2015 22:26:33 +0200

irqchip: renesas: intc-irqpin: Improve binding documentation

Add missing documentation for required properties:
  - interrupt-controller,
  - parent interrupts (one entry per provided interrupt).

Add missing documentation for optional properties:
  - functional clock (managed since commit 705bc96c2c15313c ("irqchip:
    renesas-intc-irqpin: Add minimal runtime PM support")),
  - power-domains.

Add an example, taken from r8a7740.dtsi.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1432891663-23641-1-git-send-email-geert%2Brenesas@glider.be
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 .../interrupt-controller/renesas,intc-irqpin.txt   | 39 ++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
index 4f7946a..772c550 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
@@ -13,9 +13,12 @@ Required properties:
 - reg: Base address and length of each register bank used by the external
   IRQ pins driven by the interrupt controller hardware module. The base
   addresses, length and number of required register banks varies with soctype.
-
+- interrupt-controller: Identifies the node as an interrupt controller.
 - #interrupt-cells: has to be <2>: an interrupt index and flags, as defined in
-  interrupts.txt in this directory
+  interrupts.txt in this directory.
+- interrupts: Must contain a list of interrupt specifiers. For each interrupt
+  provided by this irqpin controller instance, there must be one entry,
+  referring to the corresponding parent interrupt.
 
 Optional properties:
 
@@ -25,3 +28,35 @@ Optional properties:
   if different from the default 4 bits
 - control-parent: disable and enable interrupts on the parent interrupt
   controller, needed for some broken implementations
+- clocks: Must contain a reference to the functional clock.  This property is
+  mandatory if the hardware implements a controllable functional clock for
+  the irqpin controller instance.
+- power-domains: Must contain a reference to the power domain. This property is
+  mandatory if the irqpin controller instance is part of a controllable power
+  domain.
+
+
+Example
+-------
+
+	irqpin1: interrupt-controller@e6900004 {
+		compatible = "renesas,intc-irqpin-r8a7740",
+			     "renesas,intc-irqpin";
+		#interrupt-cells = <2>;
+		interrupt-controller;
+		reg = <0xe6900004 4>,
+			<0xe6900014 4>,
+			<0xe6900024 1>,
+			<0xe6900044 1>,
+			<0xe6900064 1>;
+		interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH
+			      0 149 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp2_clks R8A7740_CLK_INTCA>;
+		power-domains = <&pd_a4s>;
+	};

      reply	other threads:[~2015-06-08  7:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  8:08 [PATCH v3] irqchip: renesas-intc-irqpin: DT binding for sense bitfield width Guennadi Liakhovetski
2013-04-08  8:08 ` Guennadi Liakhovetski
2013-04-08  8:08 ` Guennadi Liakhovetski
2013-04-08  9:56 ` Laurent Pinchart
2013-04-08  9:56   ` Laurent Pinchart
2013-04-08  9:56   ` Laurent Pinchart
2013-04-08 11:25   ` Guennadi Liakhovetski
2013-04-08 11:25     ` Guennadi Liakhovetski
2013-04-08 11:25     ` Guennadi Liakhovetski
2013-04-08 11:37     ` Laurent Pinchart
2013-04-08 11:37       ` Laurent Pinchart
2013-04-08 11:37       ` Laurent Pinchart
2013-04-08 12:15       ` Guennadi Liakhovetski
2013-04-08 12:15         ` Guennadi Liakhovetski
2013-04-08 12:15         ` Guennadi Liakhovetski
2013-04-08 23:22         ` Laurent Pinchart
2013-04-08 23:22           ` Laurent Pinchart
2013-04-08 23:22           ` Laurent Pinchart
2013-04-09  8:44           ` Simon Horman
2013-04-09  8:44             ` Simon Horman
2013-04-09  8:44             ` Simon Horman
2013-04-09 22:23 ` Magnus Damm
2013-04-09 22:23   ` Magnus Damm
2013-04-09 22:23   ` Magnus Damm
2013-04-10  0:48   ` Simon Horman
2013-04-10  0:48     ` Simon Horman
2013-04-10  0:48     ` Simon Horman
2015-05-29  9:27 ` [PATCH v3] irqchip: renesas-intc-irqpin: Improve binding documentation Geert Uytterhoeven
2015-05-29  9:27   ` Geert Uytterhoeven
2015-06-08  7:57   ` tip-bot for Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-496c28b13eb9d4f9c751b672daad8b110084cfd8@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=geert+renesas@glider.be \
    --cc=horms+renesas@verge.net.au \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.