All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Milo Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: nicolas.ferre@atmel.com, milo.kim@ti.com, mingo@kernel.org,
	linux-kernel@vger.kernel.org, jason@lakedaemon.net,
	hpa@zytor.com, tglx@linutronix.de,
	boris.brezillon@free-electrons.com, marc.zyngier@arm.com,
	ludovic.desroches@atmel.com
Subject: [tip:irq/urgent] irqchip/atmel-aic: Fix wrong bit operation for IRQ priority
Date: Wed, 27 Jan 2016 03:57:31 -0800	[thread overview]
Message-ID: <tip-49f34134aea74f19ca016f055d25ee55ec359dee@git.kernel.org> (raw)
In-Reply-To: <1452669592-3401-2-git-send-email-milo.kim@ti.com>

Commit-ID:  49f34134aea74f19ca016f055d25ee55ec359dee
Gitweb:     http://git.kernel.org/tip/49f34134aea74f19ca016f055d25ee55ec359dee
Author:     Milo Kim <milo.kim@ti.com>
AuthorDate: Wed, 13 Jan 2016 16:19:50 +0900
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 27 Jan 2016 12:54:33 +0100

irqchip/atmel-aic: Fix wrong bit operation for IRQ priority

Atmel AIC has common structure for SMR (Source Mode Register).

  bit[6:5] Interrupt source type
  bit[2:0] Priority level
  Other bits are unused.

To update new priority value, bit[2:0] should be cleared first and then
new priority level can be written. However, aic_common_set_priority()
helper clears source type bits instead of priority bits.
This patch fixes wrong mask bit operation.

Fixes: b1479ebb7720 "irqchip: atmel-aic: Add atmel AIC/AIC5 drivers"
Signed-off-by: Milo Kim <milo.kim@ti.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: Nicholas Ferre <nicolas.ferre@atmel.com>
Cc: stable@vger.kernel.org #v3.17+
Link: http://lkml.kernel.org/r/1452669592-3401-2-git-send-email-milo.kim@ti.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-atmel-aic-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-atmel-aic-common.c b/drivers/irqchip/irq-atmel-aic-common.c
index b12a5d5..37199b9 100644
--- a/drivers/irqchip/irq-atmel-aic-common.c
+++ b/drivers/irqchip/irq-atmel-aic-common.c
@@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val)
 	    priority > AT91_AIC_IRQ_MAX_PRIORITY)
 		return -EINVAL;
 
-	*val &= AT91_AIC_PRIOR;
+	*val &= ~AT91_AIC_PRIOR;
 	*val |= priority;
 
 	return 0;

  reply	other threads:[~2016-01-27 11:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13  7:19 [PATCH 1/4] irqchip: atmel-aic: Handle aic_common_irq_fixup in aic_common_of_init Milo Kim
2016-01-13  7:19 ` [PATCH 2/4] irqchip: atmel-aic: Fix wrong bit operation for IRQ priority Milo Kim
2016-01-27 11:57   ` tip-bot for Milo Kim [this message]
2016-01-13  7:19 ` [PATCH 3/4] irqchip: atmel-aic: Change return type of aic_common_set_priority() Milo Kim
2016-01-13  8:17   ` Boris Brezillon
2016-02-08 10:49   ` [tip:irq/core] irqchip/atmel-aic: " tip-bot for Milo Kim
2016-02-08 14:06   ` tip-bot for Milo Kim
2016-01-13  7:19 ` [PATCH 4/4] irqchip: atmel-aic: Remove duplicate bit operation Milo Kim
2016-01-13  8:18   ` Boris Brezillon
2016-02-08 10:49   ` [tip:irq/core] irqchip/atmel-aic: " tip-bot for Milo Kim
2016-02-08 14:07   ` tip-bot for Milo Kim
2016-02-08 10:48 ` [tip:irq/core] irqchip/atmel-aic: Handle aic_common_irq_fixup in aic_common_of_init tip-bot for Milo Kim
2016-02-08 14:06 ` tip-bot for Milo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-49f34134aea74f19ca016f055d25ee55ec359dee@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=hpa@zytor.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=marc.zyngier@arm.com \
    --cc=milo.kim@ti.com \
    --cc=mingo@kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.