From: tip-bot for Dietmar Eggemann <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
peterz@infradead.org, dietmar.eggemann@arm.com,
Dietmar.Eggemann@arm.com, tglx@linutronix.de
Subject: [tip:sched/core] sched: Do not zero sg->cpumask and sg->sgp-> power in build_sched_groups
Date: Mon, 19 May 2014 06:09:16 -0700 [thread overview]
Message-ID: <tip-4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd@git.kernel.org> (raw)
In-Reply-To: <1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com>
Commit-ID: 4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd
Gitweb: http://git.kernel.org/tip/4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd
Author: Dietmar Eggemann <Dietmar.Eggemann@arm.com>
AuthorDate: Wed, 30 Apr 2014 14:39:38 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 19 May 2014 22:02:41 +0900
sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups
There is no need to zero struct sched_group member cpumask and struct
sched_group_power member power since both structures are already allocated
as zeroed memory in __sdt_alloc().
This patch has been tested with
BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power);
in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including
CPU hotplug scenarios.
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/sched/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index ca76cc6..354cd5a 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu)
continue;
group = get_group(i, sdd, &sg);
- cpumask_clear(sched_group_cpus(sg));
- sg->sgp->power = 0;
cpumask_setall(sched_group_mask(sg));
for_each_cpu(j, span) {
next prev parent reply other threads:[~2014-05-19 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 13:39 [PATCH] sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups Dietmar Eggemann
2014-04-30 13:46 ` Dietmar Eggemann
2014-05-13 8:32 ` Dietmar Eggemann
2014-05-13 10:32 ` Peter Zijlstra
2014-05-19 13:09 ` tip-bot for Dietmar Eggemann [this message]
2014-05-22 12:27 ` [tip:sched/core] sched: Do not zero sg->cpumask and sg->sgp-> power in build_sched_groups() tip-bot for Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dietmar.eggemann@arm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.