From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbcIEPQc (ORCPT ); Mon, 5 Sep 2016 11:16:32 -0400 Received: from terminus.zytor.com ([198.137.202.10]:41664 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753280AbcIEPQa (ORCPT ); Mon, 5 Sep 2016 11:16:30 -0400 Date: Mon, 5 Sep 2016 08:16:16 -0700 From: tip-bot for Punit Agrawal Message-ID: Cc: hpa@zytor.com, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, punit.agrawal@arm.com, mingo@kernel.org, tglx@linutronix.de Reply-To: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, punit.agrawal@arm.com, hpa@zytor.com, marc.zyngier@arm.com In-Reply-To: <1464699409-23113-1-git-send-email-punit.agrawal@arm.com> References: <1464699409-23113-1-git-send-email-punit.agrawal@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] genirq: Update stale comment for __irq_domain_add Git-Commit-ID: 545d5d657b720e9c4dc773265bb7e9d88e34b269 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 545d5d657b720e9c4dc773265bb7e9d88e34b269 Gitweb: http://git.kernel.org/tip/545d5d657b720e9c4dc773265bb7e9d88e34b269 Author: Punit Agrawal AuthorDate: Tue, 31 May 2016 13:56:48 +0100 Committer: Thomas Gleixner CommitDate: Mon, 5 Sep 2016 17:11:10 +0200 genirq: Update stale comment for __irq_domain_add Commit 1bf4ddc46c5d ("irqdomain: Introduce irq_domain_create_{linear, tree}") introduced the use of fwnode_handle to identify the interrupt controller when calling __irq_domain_add but missed updating the kernel doc parameters for the function. Update this comment. While we are touching this code, also consolidate the declaration and assignment of of_node. Signed-off-by: Punit Agrawal Acked-by: Marc Zygnier Link: http://lkml.kernel.org/r/1464699409-23113-1-git-send-email-punit.agrawal@arm.com Signed-off-by: Thomas Gleixner --- kernel/irq/irqdomain.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index f10cffe..8c0a0ae 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -80,7 +80,7 @@ EXPORT_SYMBOL_GPL(irq_domain_free_fwnode); /** * __irq_domain_add() - Allocate a new irq_domain data structure - * @of_node: optional device-tree node of the interrupt controller + * @fwnode: firmware node for the interrupt controller * @size: Size of linear map; 0 for radix mapping only * @hwirq_max: Maximum number of interrupts supported by controller * @direct_max: Maximum value of direct maps; Use ~0 for no limit; 0 for no @@ -96,10 +96,8 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size, const struct irq_domain_ops *ops, void *host_data) { + struct device_node *of_node = to_of_node(fwnode); struct irq_domain *domain; - struct device_node *of_node; - - of_node = to_of_node(fwnode); domain = kzalloc_node(sizeof(*domain) + (sizeof(unsigned int) * size), GFP_KERNEL, of_node_to_nid(of_node));