From: tip-bot for Peter Zijlstra <peterz@infradead.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
torvalds@linux-foundation.org,
nico-linux-20100709@schottelius.org, a.p.zijlstra@chello.nl,
peterz@infradead.org, flo@xssn.at, lenb@kernel.org,
jbarnes@virtuousgeek.org, suresh.b.siddha@intel.com,
tglx@linutronix.de, rjw@sisk.pl, mingo@elte.hu
Subject: [tip:sched/urgent] x86, tsc: Fix a preemption leak in restore_sched_clock_state()
Date: Sat, 11 Sep 2010 07:49:07 GMT [thread overview]
Message-ID: <tip-55496c896b8a695140045099d4e0175cf09d4eae@git.kernel.org> (raw)
In-Reply-To: <1284150773.402.122.camel@laptop>
Commit-ID: 55496c896b8a695140045099d4e0175cf09d4eae
Gitweb: http://git.kernel.org/tip/55496c896b8a695140045099d4e0175cf09d4eae
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Fri, 10 Sep 2010 22:32:53 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 11 Sep 2010 09:47:07 +0200
x86, tsc: Fix a preemption leak in restore_sched_clock_state()
Doh, a real life genuine preemption leak..
This caused a suspend failure.
Reported-bisected-and-tested-by-the-invaluable: Jeff Chua <jeff.chua.linux@gmail.com>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Nico Schottelius <nico-linux-20100709@schottelius.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Florian Pritz <flo@xssn.at>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: <stable@kernel.org> # Greg, please apply after: cd7240c ("x86, tsc, sched: Recompute cyc2ns_offset's during resume from")
sleep states
LKML-Reference: <1284150773.402.122.camel@laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/tsc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index d632934..26a863a 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -655,7 +655,7 @@ void restore_sched_clock_state(void)
local_irq_save(flags);
- get_cpu_var(cyc2ns_offset) = 0;
+ __get_cpu_var(cyc2ns_offset) = 0;
offset = cyc2ns_suspend - sched_clock();
for_each_possible_cpu(cpu)
next prev parent reply other threads:[~2010-09-11 7:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 5:36 2.6.36-rc3 suspend issue (was: 2.6.35-rc4 / X201 issues) Jeff Chua
2010-09-10 7:48 ` Peter Zijlstra
2010-09-10 11:53 ` Jeff Chua
2010-09-10 12:05 ` Peter Zijlstra
2010-09-10 17:19 ` Jeff Chua
2010-09-10 20:32 ` [PATCH] x86, tsc: Fix a preemption leak in restore_sched_clock_state() Peter Zijlstra
2010-09-10 21:01 ` Suresh Siddha
2010-09-11 0:59 ` Jeff Chua
2010-09-11 7:49 ` tip-bot for Peter Zijlstra [this message]
2010-09-13 7:42 ` [tip:sched/urgent] " Nico Schottelius
2010-09-13 8:46 ` Ingo Molnar
2010-09-13 22:56 ` Jeff Chua
2010-09-15 8:03 ` Nico Schottelius
2010-09-28 11:59 ` 2.6.36-rc3-00464-g84e1d83 resume issue (was: [tip:sched/urgent] x86, tsc: Fix a preemption leak in restore_sched_clock_state()) Nico Schottelius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-55496c896b8a695140045099d4e0175cf09d4eae@git.kernel.org \
--to=peterz@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=flo@xssn.at \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=nico-linux-20100709@schottelius.org \
--cc=rjw@sisk.pl \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.