From: tip-bot for Qiaowei Ren <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dave@sr71.net,
qiaowei.ren@intel.com, hpa@zytor.com,
dave.hansen@linux.intel.com, tglx@linutronix.de,
mingo@kernel.org
Subject: [tip:x86/mpx] x86, mpx: Add MPX-specific mmap interface
Date: Mon, 17 Nov 2014 16:06:54 -0800 [thread overview]
Message-ID: <tip-57319d80e1d328e34cb24868a4f4405661485e30@git.kernel.org> (raw)
In-Reply-To: <20141114151827.CE440F67@viggo.jf.intel.com>
Commit-ID: 57319d80e1d328e34cb24868a4f4405661485e30
Gitweb: http://git.kernel.org/tip/57319d80e1d328e34cb24868a4f4405661485e30
Author: Qiaowei Ren <qiaowei.ren@intel.com>
AuthorDate: Fri, 14 Nov 2014 07:18:27 -0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 18 Nov 2014 00:58:53 +0100
x86, mpx: Add MPX-specific mmap interface
We have chosen to perform the allocation of bounds tables in
kernel (See the patch "on-demand kernel allocation of bounds
tables") and to mark these VMAs with VM_MPX.
However, there is currently no suitable interface to actually do
this. Existing interfaces, like do_mmap_pgoff(), have no way to
set a modified ->vm_ops or ->vm_flags and don't hold mmap_sem
long enough to let a caller do it.
This patch wraps mmap_region() and hold mmap_sem long enough to
make the modifications to the VMA which we need.
Also note the 32/64-bit #ifdef in the header. We actually need
to do this at runtime eventually. But, for now, we don't support
running 32-bit binaries on 64-bit kernels. Support for this will
come in later patches.
Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-mm@kvack.org
Cc: linux-mips@linux-mips.org
Cc: Dave Hansen <dave@sr71.net>
Link: http://lkml.kernel.org/r/20141114151827.CE440F67@viggo.jf.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/Kconfig | 4 +++
arch/x86/include/asm/mpx.h | 36 +++++++++++++++++++
arch/x86/mm/Makefile | 2 ++
arch/x86/mm/mpx.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 128 insertions(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index ded8a67..967dfe0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -248,6 +248,10 @@ config HAVE_INTEL_TXT
def_bool y
depends on INTEL_IOMMU && ACPI
+config X86_INTEL_MPX
+ def_bool y
+ depends on CPU_SUP_INTEL
+
config X86_32_SMP
def_bool y
depends on X86_32 && SMP
diff --git a/arch/x86/include/asm/mpx.h b/arch/x86/include/asm/mpx.h
new file mode 100644
index 0000000..7d7c5f5
--- /dev/null
+++ b/arch/x86/include/asm/mpx.h
@@ -0,0 +1,36 @@
+#ifndef _ASM_X86_MPX_H
+#define _ASM_X86_MPX_H
+
+#include <linux/types.h>
+#include <asm/ptrace.h>
+
+#ifdef CONFIG_X86_64
+
+/* upper 28 bits [47:20] of the virtual address in 64-bit used to
+ * index into bounds directory (BD).
+ */
+#define MPX_BD_ENTRY_OFFSET 28
+#define MPX_BD_ENTRY_SHIFT 3
+/* bits [19:3] of the virtual address in 64-bit used to index into
+ * bounds table (BT).
+ */
+#define MPX_BT_ENTRY_OFFSET 17
+#define MPX_BT_ENTRY_SHIFT 5
+#define MPX_IGN_BITS 3
+
+#else
+
+#define MPX_BD_ENTRY_OFFSET 20
+#define MPX_BD_ENTRY_SHIFT 2
+#define MPX_BT_ENTRY_OFFSET 10
+#define MPX_BT_ENTRY_SHIFT 4
+#define MPX_IGN_BITS 2
+
+#endif
+
+#define MPX_BD_SIZE_BYTES (1UL<<(MPX_BD_ENTRY_OFFSET+MPX_BD_ENTRY_SHIFT))
+#define MPX_BT_SIZE_BYTES (1UL<<(MPX_BT_ENTRY_OFFSET+MPX_BT_ENTRY_SHIFT))
+
+#define MPX_BNDSTA_ERROR_CODE 0x3
+
+#endif /* _ASM_X86_MPX_H */
diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
index 6a19ad9..ecfdc46 100644
--- a/arch/x86/mm/Makefile
+++ b/arch/x86/mm/Makefile
@@ -30,3 +30,5 @@ obj-$(CONFIG_ACPI_NUMA) += srat.o
obj-$(CONFIG_NUMA_EMU) += numa_emulation.o
obj-$(CONFIG_MEMTEST) += memtest.o
+
+obj-$(CONFIG_X86_INTEL_MPX) += mpx.o
diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c
new file mode 100644
index 0000000..72d13b0
--- /dev/null
+++ b/arch/x86/mm/mpx.c
@@ -0,0 +1,86 @@
+/*
+ * mpx.c - Memory Protection eXtensions
+ *
+ * Copyright (c) 2014, Intel Corporation.
+ * Qiaowei Ren <qiaowei.ren@intel.com>
+ * Dave Hansen <dave.hansen@intel.com>
+ */
+#include <linux/kernel.h>
+#include <linux/syscalls.h>
+#include <linux/sched/sysctl.h>
+
+#include <asm/mman.h>
+#include <asm/mpx.h>
+
+static const char *mpx_mapping_name(struct vm_area_struct *vma)
+{
+ return "[mpx]";
+}
+
+static struct vm_operations_struct mpx_vma_ops = {
+ .name = mpx_mapping_name,
+};
+
+/*
+ * This is really a simplified "vm_mmap". it only handles MPX
+ * bounds tables (the bounds directory is user-allocated).
+ *
+ * Later on, we use the vma->vm_ops to uniquely identify these
+ * VMAs.
+ */
+static unsigned long mpx_mmap(unsigned long len)
+{
+ unsigned long ret;
+ unsigned long addr, pgoff;
+ struct mm_struct *mm = current->mm;
+ vm_flags_t vm_flags;
+ struct vm_area_struct *vma;
+
+ /* Only bounds table and bounds directory can be allocated here */
+ if (len != MPX_BD_SIZE_BYTES && len != MPX_BT_SIZE_BYTES)
+ return -EINVAL;
+
+ down_write(&mm->mmap_sem);
+
+ /* Too many mappings? */
+ if (mm->map_count > sysctl_max_map_count) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ /* Obtain the address to map to. we verify (or select) it and ensure
+ * that it represents a valid section of the address space.
+ */
+ addr = get_unmapped_area(NULL, 0, len, 0, MAP_ANONYMOUS | MAP_PRIVATE);
+ if (addr & ~PAGE_MASK) {
+ ret = addr;
+ goto out;
+ }
+
+ vm_flags = VM_READ | VM_WRITE | VM_MPX |
+ mm->def_flags | VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC;
+
+ /* Set pgoff according to addr for anon_vma */
+ pgoff = addr >> PAGE_SHIFT;
+
+ ret = mmap_region(NULL, addr, len, vm_flags, pgoff);
+ if (IS_ERR_VALUE(ret))
+ goto out;
+
+ vma = find_vma(mm, ret);
+ if (!vma) {
+ ret = -ENOMEM;
+ goto out;
+ }
+ vma->vm_ops = &mpx_vma_ops;
+
+ if (vm_flags & VM_LOCKED) {
+ up_write(&mm->mmap_sem);
+ mm_populate(ret, len);
+ return ret;
+ }
+
+out:
+ up_write(&mm->mmap_sem);
+ return ret;
+}
next prev parent reply other threads:[~2014-11-18 0:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 15:18 [PATCH 00/11] [v11] Intel MPX support Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` [PATCH 01/11] x86, mpx: rename cfg_reg_u and status_reg Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] x86, mpx: Rename " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 02/11] mpx: extend siginfo structure to include bound violation information Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] mpx: Extend " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 03/11] mips: sync struct siginfo with general version Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] mips: Sync " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 04/11] ia64: sync " Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:05 ` [tip:x86/mpx] ia64: Sync " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 05/11] x86, mpx: add MPX to disaabled features Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 17:56 ` Sergei Shtylyov
2014-11-14 18:38 ` Dave Hansen
2014-11-14 18:38 ` Dave Hansen
2014-11-14 18:38 ` Dave Hansen
2014-11-18 0:06 ` [tip:x86/mpx] x86, mpx: Add MPX to disabled features tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 06/11] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:06 ` [tip:x86/mpx] x86, mpx: Introduce " tip-bot for Qiaowei Ren
2014-11-14 15:18 ` [PATCH 07/11] x86, mpx: add MPX-specific mmap interface Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:06 ` tip-bot for Qiaowei Ren [this message]
2014-11-14 15:18 ` [PATCH 08/11] x86, mpx: [new code] decode MPX instruction to get bound violation information Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: Decode " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 09/11] x86, mpx: on-demand kernel allocation of bounds tables Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 16:47 ` Thomas Gleixner
2014-11-14 17:10 ` Dave Hansen
2014-11-14 17:10 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: On-demand " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 10/11] x86, mpx: cleanup unused bound tables Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:07 ` [tip:x86/mpx] x86, mpx: Cleanup " tip-bot for Dave Hansen
2014-11-14 15:18 ` [PATCH 11/11] x86, mpx: add documentation on Intel MPX Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-14 15:18 ` Dave Hansen
2014-11-18 0:08 ` [tip:x86/mpx] x86, mpx: Add " tip-bot for Qiaowei Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-57319d80e1d328e34cb24868a4f4405661485e30@git.kernel.org \
--to=tipbot@zytor.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.