From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756754AbcAIQmj (ORCPT ); Sat, 9 Jan 2016 11:42:39 -0500 Received: from terminus.zytor.com ([198.137.202.10]:42407 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755911AbcAIQmg (ORCPT ); Sat, 9 Jan 2016 11:42:36 -0500 Date: Sat, 9 Jan 2016 08:42:21 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org, namhyung@kernel.org, mingo@kernel.org, acme@redhat.com, a.p.zijlstra@chello.nl, tglx@linutronix.de, dsahern@gmail.com, noelgrandin@gmail.com, hpa@zytor.com, adrian.hunter@intel.com, jolsa@redhat.com Reply-To: mingo@kernel.org, jolsa@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, acme@redhat.com, tglx@linutronix.de, hpa@zytor.com, noelgrandin@gmail.com, dsahern@gmail.com, jolsa@redhat.com, adrian.hunter@intel.com In-Reply-To: <20160107133022.GA32115@krava.brq.redhat.com> References: <20160107133022.GA32115@krava.brq.redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf record: Store data mmaps for dwarf unwind Git-Commit-ID: 5c0cf22477eaa890beeb4bc3554e5bebbea4b007 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 5c0cf22477eaa890beeb4bc3554e5bebbea4b007 Gitweb: http://git.kernel.org/tip/5c0cf22477eaa890beeb4bc3554e5bebbea4b007 Author: Jiri Olsa AuthorDate: Thu, 7 Jan 2016 14:30:22 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 8 Jan 2016 14:17:45 -0300 perf record: Store data mmaps for dwarf unwind Currently we don't synthesize data mmap by default. It depends on -d option, that enables data address sampling. But we've seen cases (softice) where DWARF unwinder went through non executable mmaps, which we need to lookup in MAP__VARIABLE tree. Making data mmaps to be synthesized for dwarf unwind as well. Reported-by: Noel Grandin Signed-off-by: Jiri Olsa Cc: Adrian Hunter Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20160107133022.GA32115@krava.brq.redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 9c5cdc2c4..dc4e0ad 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -815,8 +815,12 @@ int record_parse_callchain_opt(const struct option *opt, } ret = parse_callchain_record_opt(arg, &callchain_param); - if (!ret) + if (!ret) { + /* Enable data address sampling for DWARF unwind. */ + if (callchain_param.record_mode == CALLCHAIN_DWARF) + record->sample_address = true; callchain_debug(); + } return ret; }