All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org,
	wangnan0@huawei.com, dsahern@gmail.com, jolsa@kernel.org,
	a.p.zijlstra@chello.nl, namhyung@kernel.org,
	linux-kernel@vger.kernel.org, acme@redhat.com
Subject: [tip:perf/urgent] perf record: Fix --switch-output documentation and comment
Date: Wed, 4 Jan 2017 23:52:11 -0800	[thread overview]
Message-ID: <tip-60437ac02f398e0ee0927748d4798dd5534ac90d@git.kernel.org> (raw)
In-Reply-To: <1483431600-19887-4-git-send-email-jolsa@kernel.org>

Commit-ID:  60437ac02f398e0ee0927748d4798dd5534ac90d
Gitweb:     http://git.kernel.org/tip/60437ac02f398e0ee0927748d4798dd5534ac90d
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Tue, 3 Jan 2017 09:19:56 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 3 Jan 2017 11:11:38 -0300

perf record: Fix --switch-output documentation and comment

There's no --signal-trigger option, also adding the code comment into
record man page.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Wang Nan <wangnan0@huawei.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1483431600-19887-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-record.txt | 4 ++++
 tools/perf/builtin-record.c              | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index 27fc361..5054d91 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -430,6 +430,10 @@ that gets then processed, possibly via a perf script, to decide if that
 particular perf.data snapshot should be kept or not.
 
 Implies --timestamp-filename, --no-buildid and --no-buildid-cache.
+The reason for the latter two is to reduce the data file switching
+overhead. You can still switch them on with:
+
+  --switch-output --no-no-buildid  --no-no-buildid-cache
 
 --dry-run::
 Parse options then exit. --dry-run can be used to detect errors in cmdline
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 31cf0ce..4ec10e9 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1636,7 +1636,7 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
 		 * overhead. Still generate buildid if they are required
 		 * explicitly using
 		 *
-		 *  perf record --signal-trigger --no-no-buildid \
+		 *  perf record --switch-output --no-no-buildid \
 		 *              --no-no-buildid-cache
 		 *
 		 * Following code equals to:

  reply	other threads:[~2017-01-05  7:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03  8:19 [PATCH 0/7] perf tools: Add switch-output size and time threshold options Jiri Olsa
2017-01-03  8:19 ` [PATCH 1/7] tools lib subcmd: Add OPT_STRING_OPTARG_SET option Jiri Olsa
2017-01-05  7:51   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-01-03  8:19 ` [PATCH 2/7] perf record: Make __record_options static Jiri Olsa
2017-01-05  7:51   ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2017-01-03  8:19 ` [PATCH 3/7] perf record: Fix --switch-output documentation and comment Jiri Olsa
2017-01-05  7:52   ` tip-bot for Jiri Olsa [this message]
2017-01-03  8:19 ` [PATCH 4/7] perf record: Add struct switch_output Jiri Olsa
2017-01-03  8:19 ` [PATCH 5/7] perf record: Change switch-output option to take optional argument Jiri Olsa
2017-01-03  8:19 ` [PATCH 6/7] perf record: Add switch-output size option argument Jiri Olsa
2017-01-03 14:20   ` Arnaldo Carvalho de Melo
2017-01-03 14:21     ` Arnaldo Carvalho de Melo
2017-01-03 14:32     ` Jiri Olsa
2017-01-03 14:49       ` Arnaldo Carvalho de Melo
2017-01-03 15:33   ` David Ahern
2017-01-03 16:12     ` Arnaldo Carvalho de Melo
2017-01-03 16:23       ` David Ahern
2017-01-03 19:42         ` Jiri Olsa
2017-01-03  8:20 ` [PATCH 7/7] perf record: Add switch-output time " Jiri Olsa
2017-01-03  9:51 ` [PATCH 0/7] perf tools: Add switch-output size and time threshold options Wangnan (F)
2017-01-03 10:39   ` Jiri Olsa
2017-01-10 13:35   ` Arnaldo Carvalho de Melo
2017-01-10 18:40     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-60437ac02f398e0ee0927748d4798dd5534ac90d@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.