From: tip-bot for Vincent Guittot <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, hegdevasant@linux.vnet.ibm.com,
torvalds@linux-foundation.org, peterz@infradead.org,
mpe@ellerman.id.au, robh+dt@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, hpa@zytor.com, anton@samba.org,
grant.likely@linaro.org, paulus@samba.org,
afleming@freescale.com, srivatsa.bhat@linux.vnet.ibm.com,
toshi.kani@hp.com, benh@kernel.crashing.org,
preeti@linux.vnet.ibm.com, vincent.guittot@linaro.org,
paul.gortmaker@windriver.com
Subject: [tip:sched/core] sched, powerpc: Create a dedicated topology table
Date: Thu, 8 May 2014 03:43:56 -0700 [thread overview]
Message-ID: <tip-607b45e9a216e89a63351556e488eea06be0ff48@git.kernel.org> (raw)
In-Reply-To: <1397209481-28542-4-git-send-email-vincent.guittot@linaro.org>
Commit-ID: 607b45e9a216e89a63351556e488eea06be0ff48
Gitweb: http://git.kernel.org/tip/607b45e9a216e89a63351556e488eea06be0ff48
Author: Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate: Fri, 11 Apr 2014 11:44:39 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 7 May 2014 13:33:51 +0200
sched, powerpc: Create a dedicated topology table
Create a dedicated topology table for handling asymetric feature of powerpc.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Andy Fleming <afleming@freescale.com>
Cc: Anton Blanchard <anton@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Preeti U. Murthy <preeti@linux.vnet.ibm.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Cc: tony.luck@intel.com
Cc: fenghua.yu@intel.com
Cc: schwidefsky@de.ibm.com
Cc: cmetcalf@tilera.com
Cc: dietmar.eggemann@arm.com
Cc: devicetree@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1397209481-28542-4-git-send-email-vincent.guittot@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/powerpc/kernel/smp.c | 31 +++++++++++++++++++++++--------
include/linux/sched.h | 2 --
kernel/sched/core.c | 6 ------
3 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index e2a4232..10ffffe 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -766,6 +766,28 @@ int setup_profiling_timer(unsigned int multiplier)
return 0;
}
+#ifdef CONFIG_SCHED_SMT
+/* cpumask of CPUs with asymetric SMT dependancy */
+static const int powerpc_smt_flags(void)
+{
+ int flags = SD_SHARE_CPUPOWER | SD_SHARE_PKG_RESOURCES;
+
+ if (cpu_has_feature(CPU_FTR_ASYM_SMT)) {
+ printk_once(KERN_INFO "Enabling Asymmetric SMT scheduling\n");
+ flags |= SD_ASYM_PACKING;
+ }
+ return flags;
+}
+#endif
+
+static struct sched_domain_topology_level powerpc_topology[] = {
+#ifdef CONFIG_SCHED_SMT
+ { cpu_smt_mask, powerpc_smt_flags, SD_INIT_NAME(SMT) },
+#endif
+ { cpu_cpu_mask, SD_INIT_NAME(DIE) },
+ { NULL, },
+};
+
void __init smp_cpus_done(unsigned int max_cpus)
{
cpumask_var_t old_mask;
@@ -790,15 +812,8 @@ void __init smp_cpus_done(unsigned int max_cpus)
dump_numa_cpu_topology();
-}
+ set_sched_topology(powerpc_topology);
-int arch_sd_sibling_asym_packing(void)
-{
- if (cpu_has_feature(CPU_FTR_ASYM_SMT)) {
- printk_once(KERN_INFO "Enabling Asymmetric SMT scheduling\n");
- return SD_ASYM_PACKING;
- }
- return 0;
}
#ifdef CONFIG_HOTPLUG_CPU
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 656b035..439a153 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -877,8 +877,6 @@ enum cpu_idle_type {
#define SD_OVERLAP 0x2000 /* sched_domains of this level overlap */
#define SD_NUMA 0x4000 /* cross-node balancing */
-extern int __weak arch_sd_sibiling_asym_packing(void);
-
#ifdef CONFIG_SCHED_SMT
static inline const int cpu_smt_flags(void)
{
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index e59e5ae..7e348e2 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5796,11 +5796,6 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd)
atomic_set(&sg->sgp->nr_busy_cpus, sg->group_weight);
}
-int __weak arch_sd_sibling_asym_packing(void)
-{
- return 0*SD_ASYM_PACKING;
-}
-
/*
* Initializers for schedule domains
* Non-inlined to reduce accumulated stack pressure in build_sched_domains()
@@ -5981,7 +5976,6 @@ sd_init(struct sched_domain_topology_level *tl, int cpu)
if (sd->flags & SD_SHARE_CPUPOWER) {
sd->imbalance_pct = 110;
sd->smt_gain = 1178; /* ~15% */
- sd->flags |= arch_sd_sibling_asym_packing();
} else if (sd->flags & SD_SHARE_PKG_RESOURCES) {
sd->imbalance_pct = 117;
next prev parent reply other threads:[~2014-05-08 10:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 9:44 [PATCH v4 0/5] rework sched_domain topology description Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-04-11 9:44 ` [PATCH v4 1/5] sched: rework of sched_domain topology definition Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-04-18 10:56 ` Peter Zijlstra
2014-04-18 10:56 ` Peter Zijlstra
2014-04-18 11:34 ` [PATCH] fix: " Vincent Guittot
2014-04-18 11:34 ` Vincent Guittot
2014-04-18 11:39 ` Peter Zijlstra
2014-04-18 11:39 ` Peter Zijlstra
2014-04-18 11:34 ` [PATCH v4 1/5] " Vincent Guittot
2014-04-18 11:34 ` Vincent Guittot
2014-05-08 10:43 ` [tip:sched/core] sched: Rework " tip-bot for Vincent Guittot
2014-05-16 9:57 ` James Hogan
2014-05-18 8:04 ` Vincent Guittot
2014-05-18 8:04 ` Vincent Guittot
2014-04-11 9:44 ` [PATCH v4 2/5] sched: s390: create a dedicated topology table Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-05-08 10:43 ` [tip:sched/core] sched, s390: Create " tip-bot for Vincent Guittot
2014-04-11 9:44 ` [PATCH v4 3/5] sched: powerpc: create " Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-05-08 10:43 ` tip-bot for Vincent Guittot [this message]
2014-04-11 9:44 ` [PATCH v4 4/5] sched: add a new SD_SHARE_POWERDOMAIN for sched_domain Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-04-18 10:58 ` Peter Zijlstra
2014-04-18 10:58 ` Peter Zijlstra
2014-04-18 11:54 ` [PATCH] fix: sched: rework of sched_domain topology definition Vincent Guittot
2014-04-18 11:54 ` Vincent Guittot
2014-04-18 11:54 ` [PATCH v4 4/5] sched: add a new SD_SHARE_POWERDOMAIN for sched_domain Vincent Guittot
2014-04-18 11:54 ` Vincent Guittot
2014-05-08 10:44 ` [tip:sched/core] sched: Add " tip-bot for Vincent Guittot
2014-04-11 9:44 ` [PATCH v4 5/5] sched: ARM: create a dedicated scheduler topology table Vincent Guittot
2014-04-11 9:44 ` Vincent Guittot
2014-04-23 11:46 ` Dietmar Eggemann
2014-04-23 11:46 ` Dietmar Eggemann
2014-04-23 14:46 ` Vincent Guittot
2014-04-23 14:46 ` Vincent Guittot
2014-04-23 15:26 ` Dietmar Eggemann
2014-04-23 15:26 ` Dietmar Eggemann
2014-04-24 7:30 ` Vincent Guittot
2014-04-24 7:30 ` Vincent Guittot
2014-04-24 12:48 ` Dietmar Eggemann
2014-04-24 12:48 ` Dietmar Eggemann
2014-04-25 7:45 ` Vincent Guittot
2014-04-25 7:45 ` Vincent Guittot
2014-04-25 15:55 ` Dietmar Eggemann
2014-04-25 15:55 ` Dietmar Eggemann
2014-04-25 16:04 ` Peter Zijlstra
2014-04-25 16:04 ` Peter Zijlstra
2014-04-25 16:05 ` Peter Zijlstra
2014-04-25 16:05 ` Peter Zijlstra
2014-05-08 10:44 ` [tip:sched/core] sched, ARM: Create " tip-bot for Vincent Guittot
2014-04-12 12:56 ` [PATCH v4 0/5] rework sched_domain topology description Dietmar Eggemann
2014-04-12 12:56 ` Dietmar Eggemann
2014-04-14 7:29 ` Vincent Guittot
2014-04-14 7:29 ` Vincent Guittot
2014-04-15 7:53 ` Peter Zijlstra
2014-04-15 7:53 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-607b45e9a216e89a63351556e488eea06be0ff48@git.kernel.org \
--to=tipbot@zytor.com \
--cc=afleming@freescale.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@linaro.org \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=robh+dt@kernel.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hp.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.