All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Arnaldo Carvalho de Melo <acme@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com,
	mingo@redhat.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perfcounters/core] perf report: Tidy up reporting of symbols not found
Date: Sat, 11 Jul 2009 17:24:53 GMT	[thread overview]
Message-ID: <tip-60c1baf1248e00d423604f018c8af1cf750ad885@git.kernel.org> (raw)
In-Reply-To: <1247325517-12272-1-git-send-email-acme@redhat.com>

Commit-ID:  60c1baf1248e00d423604f018c8af1cf750ad885
Gitweb:     http://git.kernel.org/tip/60c1baf1248e00d423604f018c8af1cf750ad885
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Sat, 11 Jul 2009 12:18:33 -0300
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 11 Jul 2009 19:20:25 +0200

perf report: Tidy up reporting of symbols not found

Always printing the level info about if it is in the kernel,
hypervisor or userspace as that is in the hist_entry.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1247325517-12272-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 tools/perf/builtin-report.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 740da43..617f4cb 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -705,10 +705,9 @@ sort__sym_print(FILE *fp, struct hist_entry *self, unsigned int width __used)
 	if (verbose)
 		ret += repsep_fprintf(fp, "%#018llx  ", (u64)self->ip);
 
+	ret += repsep_fprintf(fp, "[%c] ", self->level);
 	if (self->sym) {
-		ret += repsep_fprintf(fp, "[%c] %s",
-			self->dso == kernel_dso ? 'k' :
-			self->dso == hypervisor_dso ? 'h' : '.', self->sym->name);
+		ret += repsep_fprintf(fp, "%s", self->sym->name);
 
 		if (self->sym->module)
 			ret += repsep_fprintf(fp, "\t[%s]",

      parent reply	other threads:[~2009-07-11 17:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11 15:18 [PATCH tip 1/5] perf report: Tidy up reporting of symbols not found Arnaldo Carvalho de Melo
2009-07-11 15:18 ` [PATCH tip 2/5] strlist: Introduce strlist__entry and strlist__nr_entries methods Arnaldo Carvalho de Melo
2009-07-11 15:18   ` [PATCH tip 3/5] perf report: Make the output more compact Arnaldo Carvalho de Melo
2009-07-11 15:18     ` [PATCH tip 4/5] perf_counter tools: PLT info is stripped in -debuginfo packages Arnaldo Carvalho de Melo
2009-07-11 15:18       ` [PATCH tip 5/5] perf report: Introduce -n/--show-nr-samples Arnaldo Carvalho de Melo
2009-07-11 17:25         ` [tip:perfcounters/core] " tip-bot for Arnaldo Carvalho de Melo
2009-07-11 17:25       ` [tip:perfcounters/core] perf_counter tools: PLT info is stripped in -debuginfo packages tip-bot for Arnaldo Carvalho de Melo
2009-07-11 15:31     ` [PATCH tip 3/5] perf report: Make the output more compact Arnaldo Carvalho de Melo
2009-07-11 17:25     ` [tip:perfcounters/core] " tip-bot for Arnaldo Carvalho de Melo
2009-07-11 17:25   ` [tip:perfcounters/core] strlist: Introduce strlist__entry and strlist__nr_entries methods tip-bot for Arnaldo Carvalho de Melo
2009-07-11 17:24 ` tip-bot for Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-60c1baf1248e00d423604f018c8af1cf750ad885@git.kernel.org \
    --to=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.