From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761988Ab2ERMLv (ORCPT ); Fri, 18 May 2012 08:11:51 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43276 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755086Ab2ERMLt (ORCPT ); Fri, 18 May 2012 08:11:49 -0400 Date: Fri, 18 May 2012 05:11:19 -0700 From: tip-bot for Seiji Aguchi Message-ID: Cc: linux-kernel@vger.kernel.org, satoru.moriya@hds.com, hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl, seiji.aguchi@hds.com, tony.luck@intel.com, dle-develop@lists.sourceforge.net, tglx@linutronix.de, dzickus@redhat.com Reply-To: mingo@kernel.org, hpa@zytor.com, satoru.moriya@hds.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, seiji.aguchi@hds.com, tony.luck@intel.com, dle-develop@lists.sourceforge.net, tglx@linutronix.de, dzickus@redhat.com In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com> References: <5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/debug] kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() Git-Commit-ID: 62be73eafaa045d3233337303fb140f7f8a61135 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.6 (terminus.zytor.com [127.0.0.1]); Fri, 18 May 2012 05:11:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 62be73eafaa045d3233337303fb140f7f8a61135 Gitweb: http://git.kernel.org/tip/62be73eafaa045d3233337303fb140f7f8a61135 Author: Seiji Aguchi AuthorDate: Tue, 15 May 2012 17:35:09 -0400 Committer: Ingo Molnar CommitDate: Fri, 18 May 2012 14:02:10 +0200 kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop() This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(), to serialize the crash-logging process via smp_send_stop() and to thus retrieve a more stable crash image of all CPUs stopped. Signed-off-by: Seiji Aguchi Acked-by: Don Zickus Cc: dle-develop@lists.sourceforge.net Cc: Satoru Moriya Cc: Tony Luck Cc: a.p.zijlstra@chello.nl Link: http://lkml.kernel.org/r/5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com Signed-off-by: Ingo Molnar --- kernel/panic.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index b6215b7..d2a5f4e 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -108,8 +108,6 @@ void panic(const char *fmt, ...) */ crash_kexec(NULL); - kmsg_dump(KMSG_DUMP_PANIC); - /* * Note smp_send_stop is the usual smp shutdown function, which * unfortunately means it may not be hardened to work in a panic @@ -117,6 +115,8 @@ void panic(const char *fmt, ...) */ smp_send_stop(); + kmsg_dump(KMSG_DUMP_PANIC); + atomic_notifier_call_chain(&panic_notifier_list, 0, buf); bust_spinlocks(0);