From: tip-bot for Hans de Goede <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
hdegoede@redhat.com, tglx@linutronix.de,
maxime.ripard@free-electrons.com
Subject: [tip:irq/core] irqchip: sun4i: Fix a comment about mask register initialization
Date: Fri, 14 Mar 2014 05:55:34 -0700 [thread overview]
Message-ID: <tip-649ff46e5e29868e915354ed1e9bebcf0faec3ae@git.kernel.org> (raw)
In-Reply-To: <1394733834-26839-4-git-send-email-hdegoede@redhat.com>
Commit-ID: 649ff46e5e29868e915354ed1e9bebcf0faec3ae
Gitweb: http://git.kernel.org/tip/649ff46e5e29868e915354ed1e9bebcf0faec3ae
Author: Hans de Goede <hdegoede@redhat.com>
AuthorDate: Thu, 13 Mar 2014 19:03:53 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Mar 2014 13:43:33 +0100
irqchip: sun4i: Fix a comment about mask register initialization
The comment was claiming that we were masking all irqs, while the code actually
*un*masks all of them.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@googlegroups.com
Link: http://lkml.kernel.org/r/1394733834-26839-4-git-send-email-hdegoede@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c
index 7ae85ec..60a28c6 100644
--- a/drivers/irqchip/irq-sun4i.c
+++ b/drivers/irqchip/irq-sun4i.c
@@ -109,7 +109,7 @@ static int __init sun4i_of_init(struct device_node *node,
writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(1));
writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(2));
- /* Mask all the interrupts */
+ /* Unmask all the interrupts, ENABLE_REG(x) is used for masking */
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(0));
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(1));
writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(2));
next prev parent reply other threads:[~2014-03-14 12:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 18:03 [PATCH v3 0/4] irq: sun4i IRQ 0 / ENMI fixes Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` [PATCH v3 1/4] irq: Add a new IRQCHIP_EOI_THREADED flag Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:17 ` Hans de Goede
2014-03-13 18:17 ` Hans de Goede
2014-03-13 18:17 ` Hans de Goede
2014-03-14 12:55 ` [tip:irq/core] genirq: " tip-bot for Thomas Gleixner
2014-03-13 18:03 ` [PATCH v3 2/4] irqchip: sun4i: Fix irq 0 not working Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-14 12:55 ` [tip:irq/core] " tip-bot for Hans de Goede
2014-03-13 18:03 ` [PATCH v3 3/4] irqchip: sun4i: Fix a comment about mask register initialization Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-14 12:55 ` tip-bot for Hans de Goede [this message]
2014-03-13 18:03 ` [PATCH v3 4/4] irqchip: sun4i: Don't ack IRQs != 0, fix acking of IRQ 0 Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-13 18:03 ` Hans de Goede
2014-03-14 12:55 ` [tip:irq/core] irqchip: sun4i: Don't ack IRQs > " tip-bot for Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-649ff46e5e29868e915354ed1e9bebcf0faec3ae@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.