From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752808AbbHSXXX (ORCPT ); Wed, 19 Aug 2015 19:23:23 -0400 Received: from terminus.zytor.com ([198.137.202.10]:57915 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbbHSXXV (ORCPT ); Wed, 19 Aug 2015 19:23:21 -0400 Date: Wed, 19 Aug 2015 16:21:39 -0700 From: tip-bot for Grygorii Strashko Message-ID: Cc: tony@atomide.com, hpa@zytor.com, mingo@kernel.org, jason@lakedaemon.net, sudeep.holla@arm.com, balbi@ti.com, grygorii.strashko@ti.com, jiang.liu@linux.intel.com, marc.zyngier@arm.com, linux@arm.linux.org.uk, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com Reply-To: nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, tglx@linutronix.de, marc.zyngier@arm.com, jiang.liu@linux.intel.com, grygorii.strashko@ti.com, sudeep.holla@arm.com, balbi@ti.com, jason@lakedaemon.net, mingo@kernel.org, hpa@zytor.com, tony@atomide.com In-Reply-To: <1439554830-19502-2-git-send-email-grygorii.strashko@ti.com> References: <1439554830-19502-2-git-send-email-grygorii.strashko@ti.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] genirq: Don' t return ENOSYS in irq_chip_retrigger_hierarchy Git-Commit-ID: 6d4affea7d5aa5ca5ff4c3e5fbf3ee16801cc527 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 6d4affea7d5aa5ca5ff4c3e5fbf3ee16801cc527 Gitweb: http://git.kernel.org/tip/6d4affea7d5aa5ca5ff4c3e5fbf3ee16801cc527 Author: Grygorii Strashko AuthorDate: Fri, 14 Aug 2015 15:20:25 +0300 Committer: Thomas Gleixner CommitDate: Thu, 20 Aug 2015 00:25:25 +0200 genirq: Don't return ENOSYS in irq_chip_retrigger_hierarchy irq_chip_retrigger_hierarchy() returns -ENOSYS if it was not able to find at least one .irq_retrigger() callback implemented in the IRQ domain hierarchy. That's wrong, because check_irq_resend() expects a 0 return value from the callback in case that the hardware assisted resend was not possible. If the return value is non zero the core code assumes hardware resend success and the software resend is not invoked. This results in lost interrupts on platforms where none of the parent irq chips in the hierarchy implements the retrigger callback. This is observable on TI OMAP, where the hierarchy is: ARM GIC <- OMAP wakeupgen <- TI Crossbar Return 0 instead so the software resend mechanism gets invoked. [ tglx: Massaged changelog ] Fixes: 85f08c17de26 ('genirq: Introduce helper functions...') Signed-off-by: Grygorii Strashko Reviewed-by: Marc Zyngier Reviewed-by: Jiang Liu Cc: Sudeep Holla Cc: Cc: Cc: Cc: Cc: Cc: Cc: stable@vger.kernel.org # 4.1 Link: http://lkml.kernel.org/r/1439554830-19502-2-git-send-email-grygorii.strashko@ti.com Signed-off-by: Thomas Gleixner --- kernel/irq/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 27f4332..6de638b 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -997,7 +997,7 @@ int irq_chip_retrigger_hierarchy(struct irq_data *data) if (data->chip && data->chip->irq_retrigger) return data->chip->irq_retrigger(data); - return -ENOSYS; + return 0; } /**