All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, jolsa@kernel.org,
	namhyung@kernel.org, pi3orama@163.com, mingo@kernel.org,
	dsahern@gmail.com, tglx@linutronix.de, a.p.zijlstra@chello.nl,
	acme@redhat.com, lizefan@huawei.com, wangnan0@huawei.com
Subject: [tip:perf/core] tools build feature: Move dwarf post unwind choice output into perf
Date: Sat, 9 Jan 2016 08:27:12 -0800	[thread overview]
Message-ID: <tip-76ee2ff342743e57cb6dc059d0aba90e0c4c9bfc@git.kernel.org> (raw)
In-Reply-To: <1450893514-9158-3-git-send-email-jolsa@kernel.org>

Commit-ID:  76ee2ff342743e57cb6dc059d0aba90e0c4c9bfc
Gitweb:     http://git.kernel.org/tip/76ee2ff342743e57cb6dc059d0aba90e0c4c9bfc
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Wed, 23 Dec 2015 18:58:31 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 6 Jan 2016 20:11:13 -0300

tools build feature: Move dwarf post unwind choice output into perf

We decide what dwarf unwind to choose way after the Makefile.feature
makefile is included. The $(dwarf-post-unwind) is not even set at that
time. For the same reason it was never included in FEATURE-DUMP file.

Moving it into perf VF=1 verbose display.

  $ make VF=1
    BUILD:   Doing 'make -j4' parallel build
  Auto-detecting system features:
  ...                         dwarf: [ on  ]
  ...
  ...                 LIBUNWIND_DIR:
  ...                     LIBDW_DIR:
  ...     DWARF post unwind library: libunwind
  ...

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Wang Nan <wangnan0@huawei.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama <pi3orama@163.com>
Link: http://lkml.kernel.org/r/1450893514-9158-3-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/Makefile.feature | 9 ---------
 tools/perf/config/Makefile   | 4 ++++
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index a8b4bef..2075312 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -126,10 +126,6 @@ FEATURE_DUMP_FILENAME = $(OUTPUT)FEATURE-DUMP$(FEATURE_USER)
 FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)($(feature-$(feat))))
 FEATURE_DUMP_FILE := $(shell touch $(FEATURE_DUMP_FILENAME); cat $(FEATURE_DUMP_FILENAME))
 
-ifeq ($(dwarf-post-unwind),1)
-  FEATURE_DUMP += dwarf-post-unwind($(dwarf-post-unwind-text))
-endif
-
 # The $(feature_display) controls the default detection message
 # output. It's set if:
 # - detected features differes from stored features from
@@ -160,11 +156,6 @@ ifeq ($(feature_display),1)
   $(info )
   $(info Auto-detecting system features:)
   $(foreach feat,$(FEATURE_DISPLAY),$(call feature_print_status,$(feat),))
-
-  ifeq ($(dwarf-post-unwind),1)
-    $(call feature_print_text,"DWARF post unwind library", $(dwarf-post-unwind-text))
-  endif
-
   ifneq ($(feature_verbose),1)
     $(info )
   endif
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index a552417..18b2f96 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -751,6 +751,10 @@ ifeq ($(VF),1)
   $(call print_var,sysconfdir)
   $(call print_var,LIBUNWIND_DIR)
   $(call print_var,LIBDW_DIR)
+
+  ifeq ($(dwarf-post-unwind),1)
+    $(call feature_print_text,"DWARF post unwind library", $(dwarf-post-unwind-text))
+  endif
   $(info )
 endif
 

  reply	other threads:[~2016-01-09 16:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 17:58 [PATCH 0/5] tools build: Make FEATURE_DUMP include makefile Jiri Olsa
2015-12-23 17:58 ` [PATCH 1/5] tools build feature: Fix feature_check_display_code typo Jiri Olsa
2016-01-09 16:26   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-23 17:58 ` [PATCH 2/5] tools build feature: Move dwarf post unwind choice output into perf Jiri Olsa
2016-01-09 16:27   ` tip-bot for Jiri Olsa [this message]
2015-12-23 17:58 ` [PATCH 3/5] tools build feature: Introduce feature_ass macro Jiri Olsa
2016-01-09 16:27   ` [tip:perf/core] tools build feature: Introduce feature_assign macro tip-bot for Jiri Olsa
2015-12-23 17:58 ` [PATCH 4/5] tools build feature: Use value assignment form for FEATURE-DUMP file Jiri Olsa
2016-01-09 16:27   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-23 17:58 ` [PATCH 5/5] perf build: Use FEATURE-DUMP in bpf subproject Jiri Olsa
2016-01-09 16:28   ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-24  2:52 ` [PATCH 0/5] tools build: Make FEATURE_DUMP include makefile Wangnan (F)
2015-12-27 11:58   ` Jiri Olsa
2016-01-04 21:06     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-76ee2ff342743e57cb6dc059d0aba90e0c4c9bfc@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.