From: tip-bot for John Stultz <john.stultz@linaro.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
hpa@zytor.com, mingo@kernel.org, schwab@linux-m68k.org,
tglx@linutronix.de, prarit@redhat.com
Subject: [tip:timers/urgent] time: Ensure we normalize the timekeeper in tk_xtime_add
Date: Wed, 22 Aug 2012 01:50:13 -0700 [thread overview]
Message-ID: <tip-784ffcbb96c3a97b4c64fd48b1dfe12ef3fcbcda@git.kernel.org> (raw)
In-Reply-To: <1345595449-34965-2-git-send-email-john.stultz@linaro.org>
Commit-ID: 784ffcbb96c3a97b4c64fd48b1dfe12ef3fcbcda
Gitweb: http://git.kernel.org/tip/784ffcbb96c3a97b4c64fd48b1dfe12ef3fcbcda
Author: John Stultz <john.stultz@linaro.org>
AuthorDate: Tue, 21 Aug 2012 20:30:46 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 22 Aug 2012 10:42:12 +0200
time: Ensure we normalize the timekeeper in tk_xtime_add
Andreas noticed problems with resume on specific hardware after commit
1e75fa8b (time: Condense timekeeper.xtime into xtime_sec) combined
with commit b44d50dca (time: Fix casting issue in tk_set_xtime and
tk_xtime_add)
After some digging I realized we aren't normalizing the timekeeper
after the add. Add the missing normalize call.
Reported-by: Andreas Schwab <schwab@linux-m68k.org>
Tested-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Link: http://lkml.kernel.org/r/1345595449-34965-2-git-send-email-john.stultz@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/timekeeping.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 898bef0..258164a 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
{
tk->xtime_sec += ts->tv_sec;
tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
+ tk_normalize_xtime(tk);
}
static void tk_set_wall_to_mono(struct timekeeper *tk, struct timespec wtm)
next prev parent reply other threads:[~2012-08-22 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 0:30 [PATCH 0/4] Time fixes for 3.6 John Stultz
2012-08-22 0:30 ` [PATCH 1/4] time: Ensure we normalize the timekeeper in tk_xtime_add John Stultz
2012-08-22 8:50 ` tip-bot for John Stultz [this message]
2012-08-22 0:30 ` [PATCH 2/4] time: Fix casting issue in timekeeping_forward_now John Stultz
2012-08-22 8:51 ` [tip:timers/urgent] " tip-bot for Andreas Schwab
2012-08-22 0:30 ` [PATCH 3/4] time: Avoid potential shift-overflow with large shift values John Stultz
2012-08-22 8:11 ` Geert Uytterhoeven
2012-08-22 8:52 ` [tip:timers/urgent] time: Avoid potential shift overflow " tip-bot for John Stultz
2012-08-22 0:30 ` [PATCH 4/4] time: Avoid making adjustments if we havne't accumulated anything John Stultz
2012-08-22 8:52 ` [tip:timers/urgent] time: Avoid making adjustments if we haven' t " tip-bot for John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-784ffcbb96c3a97b4c64fd48b1dfe12ef3fcbcda@git.kernel.org \
--to=john.stultz@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=schwab@linux-m68k.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.