All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Ben Greear <greearb@candelatech.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	rostedt@goodmis.org, greearb@candelatech.com, tglx@linutronix.de
Subject: [tip:core/locking] lockdep: Print more info when MAX_LOCK_DEPTH is exceeded
Date: Thu, 7 Feb 2013 04:12:34 -0800	[thread overview]
Message-ID: <tip-7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791@git.kernel.org> (raw)
In-Reply-To: <1360176979-4421-1-git-send-email-greearb@candelatech.com>

Commit-ID:  7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791
Gitweb:     http://git.kernel.org/tip/7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791
Author:     Ben Greear <greearb@candelatech.com>
AuthorDate: Wed, 6 Feb 2013 10:56:19 -0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 7 Feb 2013 12:17:43 +0100

lockdep: Print more info when MAX_LOCK_DEPTH is exceeded

This helps debug cases where a lock is acquired over and
over without being released.

Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ben Greear <greearb@candelatech.com>
Cc: peterz@infradead.org
Link: http://lkml.kernel.org/r/1360176979-4421-1-git-send-email-greearb@candelatech.com
[ Changed the printout ordering. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/lockdep.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index c783e80..1966746 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3192,9 +3192,14 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
 #endif
 	if (unlikely(curr->lockdep_depth >= MAX_LOCK_DEPTH)) {
 		debug_locks_off();
-		printk("BUG: MAX_LOCK_DEPTH too low!\n");
+		printk("BUG: MAX_LOCK_DEPTH too low, depth: %i  max: %lu!\n",
+		       curr->lockdep_depth, MAX_LOCK_DEPTH);
 		printk("turning off the locking correctness validator.\n");
+
+		lockdep_print_held_locks(current);
+		debug_show_all_locks();
 		dump_stack();
+
 		return 0;
 	}
 

  reply	other threads:[~2013-02-07 12:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 18:56 [PATCH] lockdep: Print more info when MAX_LOCK_DEPTH is exceeded greearb
2013-02-07 12:12 ` tip-bot for Ben Greear [this message]
2013-02-22 12:26 ` [tip:core/locking] " tip-bot for Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7a508076d4efdfd4fcb6fbd50a32d2c1a6e98791@git.kernel.org \
    --to=greearb@candelatech.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.