All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Fenghua Yu <fenghua.yu@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	fenghua.yu@intel.com, tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/bsp-hotplug] x86, hotplug, suspend: Online CPU0 for suspend or hibernate
Date: Mon, 27 Aug 2012 10:10:56 -0700	[thread overview]
Message-ID: <tip-7d3b04f27e44b7bd264249161fdd727a1732aea0@git.kernel.org> (raw)
In-Reply-To: <1345916488-8355-6-git-send-email-fenghua.yu@intel.com>

Commit-ID:  7d3b04f27e44b7bd264249161fdd727a1732aea0
Gitweb:     http://git.kernel.org/tip/7d3b04f27e44b7bd264249161fdd727a1732aea0
Author:     Fenghua Yu <fenghua.yu@intel.com>
AuthorDate: Sat, 25 Aug 2012 10:41:21 -0700
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Sat, 25 Aug 2012 19:26:05 -0700

x86, hotplug, suspend: Online CPU0 for suspend or hibernate

Because x86 BIOS requires CPU0 to resume from sleep, suspend or hibernate can't
be executed if CPU0 is detected offline. To make suspend or hibernate and
further resume succeed, CPU0 must be online.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Link: http://lkml.kernel.org/r/1345916488-8355-6-git-send-email-fenghua.yu@intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/power/cpu.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 44 insertions(+), 0 deletions(-)

diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
index 218cdb1..3338609 100644
--- a/arch/x86/power/cpu.c
+++ b/arch/x86/power/cpu.c
@@ -237,3 +237,47 @@ void restore_processor_state(void)
 #ifdef CONFIG_X86_32
 EXPORT_SYMBOL(restore_processor_state);
 #endif
+
+/*
+ * When bsp_check() is called in hibernate and suspend, cpu hotplug
+ * is disabled already. So it's unnessary to handle race condition between
+ * cpumask query and cpu hotplug.
+ */
+static int bsp_check(void)
+{
+	if (cpumask_first(cpu_online_mask) != 0) {
+		printk(KERN_WARNING "CPU0 is offline.\n");
+		return -ENODEV;
+	}
+
+	return 0;
+}
+
+static int bsp_pm_callback(struct notifier_block *nb, unsigned long action,
+			   void *ptr)
+{
+	int ret = 0;
+
+	switch (action) {
+	case PM_SUSPEND_PREPARE:
+	case PM_HIBERNATION_PREPARE:
+		ret = bsp_check();
+		break;
+	default:
+		break;
+	}
+	return notifier_from_errno(ret);
+}
+
+static int __init bsp_pm_check_init(void)
+{
+	/*
+	 * Set this bsp_pm_callback as lower priority than
+	 * cpu_hotplug_pm_callback. So cpu_hotplug_pm_callback will be called
+	 * earlier to disable cpu hotplug before bsp online check.
+	 */
+	pm_notifier(bsp_pm_callback, -INT_MAX);
+	return 0;
+}
+
+core_initcall(bsp_pm_check_init);

  reply	other threads:[~2012-08-27 17:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-25 17:41 [PATCH v8 0/12] x86: Arbitrary CPU hot(un)plug support Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 01/12] doc: Add x86 CPU0 online/offline feature Fenghua Yu
2012-08-27 17:07   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 02/12] x86, Kconfig: Add config switch for CPU0 hotplug Fenghua Yu
2012-08-27 17:08   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 03/12] x86, topology: Don't offline CPU0 if any PIC irq can not be migrated out of it Fenghua Yu
2012-08-27 17:09   ` [tip:x86/bsp-hotplug] x86, topology: Don' t " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 04/12] x86, hotplug: Support functions for CPU0 online/offline Fenghua Yu
2012-08-27 17:10   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 05/12] x86, hotplug, suspend: Online CPU0 for suspend or hibernate Fenghua Yu
2012-08-27 17:10   ` tip-bot for Fenghua Yu [this message]
2012-08-25 17:41 ` [PATCH v8 06/12] x86-64, hotplug: Add start_cpu0() entry point to head_64.S Fenghua Yu
2012-08-27 17:11   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 07/12] x86-32, hotplug: Add start_cpu0() entry point to head_32.S Fenghua Yu
2012-08-27 17:12   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 08/12] x86, hotplug: Wake up CPU0 via NMI instead of INIT, SIPI, SIPI Fenghua Yu
2012-08-27 17:13   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 09/12] x86, hotplug: During CPU0 online, enable x2apic, set_numa_node Fenghua Yu
2012-08-27 17:14   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 10/12] x86, hotplug: The first online processor saves the MTRR state Fenghua Yu
2012-08-27 17:15   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 11/12] x86/i387.c: Initialize thread xstate only on CPU0 only once Fenghua Yu
2012-08-27 17:16   ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu
2012-08-25 17:41 ` [PATCH v8 12/12] x86, topology: Debug CPU00 hotplug Fenghua Yu
2012-08-27 17:17   ` [tip:x86/bsp-hotplug] x86, topology: Debug CPU0 hotplug tip-bot for Fenghua Yu
2012-09-10  5:50 ` [PATCH v8 0/12] x86: Arbitrary CPU hot(un)plug support Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2012-11-13 19:32 [PATCH v10 05/14] x86, hotplug, suspend: Online CPU0 for suspend or hibernate Fenghua Yu
2012-11-14 21:25 ` [tip:x86/bsp-hotplug] " tip-bot for Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-7d3b04f27e44b7bd264249161fdd727a1732aea0@git.kernel.org \
    --to=fenghua.yu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.