From: tip-bot for Suresh Siddha <suresh.b.siddha@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
joerg.roedel@amd.com, suresh.b.siddha@intel.com,
tglx@linutronix.de
Subject: [tip:core/iommu] irq_remap: Fix UP build failure
Date: Tue, 8 May 2012 03:02:32 -0700 [thread overview]
Message-ID: <tip-82b481e80d8a17720b5805393684a95184cfb6bb@git.kernel.org> (raw)
In-Reply-To: <1336460934-23592-2-git-send-email-suresh.b.siddha@intel.com>
Commit-ID: 82b481e80d8a17720b5805393684a95184cfb6bb
Gitweb: http://git.kernel.org/tip/82b481e80d8a17720b5805393684a95184cfb6bb
Author: Suresh Siddha <suresh.b.siddha@intel.com>
AuthorDate: Tue, 8 May 2012 00:08:53 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 8 May 2012 11:17:30 +0200
irq_remap: Fix UP build failure
Fix the below UP build failure with CONFIG_IRQ_REMAP enabled.
drivers/iommu/intel_irq_remapping.c:955:19: error: ‘struct irq_data’ has no member named ‘affinity’
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: joro@8bytes.org
Cc: iommu@lists.linux-foundation.org
Cc: Joerg Roedel <joerg.roedel@amd.com>
Link: http://lkml.kernel.org/r/1336460934-23592-2-git-send-email-suresh.b.siddha@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/iommu/intel_irq_remapping.c | 4 ++++
drivers/iommu/irq_remapping.c | 2 ++
drivers/iommu/irq_remapping.h | 2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index b4d3950..1c0255e 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -902,6 +902,7 @@ static int intel_setup_ioapic_entry(int irq,
return 0;
}
+#ifdef CONFIG_SMP
/*
* Migrate the IO-APIC irq in the presence of intr-remapping.
*
@@ -955,6 +956,7 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask,
cpumask_copy(data->affinity, mask);
return 0;
}
+#endif
static void intel_compose_msi_msg(struct pci_dev *pdev,
unsigned int irq, unsigned int dest,
@@ -1056,7 +1058,9 @@ struct irq_remap_ops intel_irq_remap_ops = {
.reenable = reenable_irq_remapping,
.enable_faulting = enable_drhd_fault_handling,
.setup_ioapic_entry = intel_setup_ioapic_entry,
+#ifdef CONFIG_SMP
.set_affinity = intel_ioapic_set_affinity,
+#endif
.free_irq = free_irte,
.compose_msi_msg = intel_compose_msi_msg,
.msi_alloc_irq = intel_msi_alloc_irq,
diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c
index 1cf350e..40cda8e 100644
--- a/drivers/iommu/irq_remapping.c
+++ b/drivers/iommu/irq_remapping.c
@@ -111,6 +111,7 @@ int setup_ioapic_remapped_entry(int irq,
vector, attr);
}
+#ifdef CONFIG_SMP
int set_remapped_irq_affinity(struct irq_data *data, const struct cpumask *mask,
bool force)
{
@@ -119,6 +120,7 @@ int set_remapped_irq_affinity(struct irq_data *data, const struct cpumask *mask,
return remap_ops->set_affinity(data, mask, force);
}
+#endif
void free_remapped_irq(int irq)
{
diff --git a/drivers/iommu/irq_remapping.h b/drivers/iommu/irq_remapping.h
index b12974c..be9d729 100644
--- a/drivers/iommu/irq_remapping.h
+++ b/drivers/iommu/irq_remapping.h
@@ -59,9 +59,11 @@ struct irq_remap_ops {
unsigned int, int,
struct io_apic_irq_attr *);
+#ifdef CONFIG_SMP
/* Set the CPU affinity of a remapped interrupt */
int (*set_affinity)(struct irq_data *data, const struct cpumask *mask,
bool force);
+#endif
/* Free an IRQ */
int (*free_irq)(int);
next prev parent reply other threads:[~2012-05-08 10:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:54 [git pull] irq remapping ops for x86 Joerg Roedel
2012-05-07 13:54 ` Joerg Roedel
2012-05-08 3:51 ` Ingo Molnar
[not found] ` <20120508035153.GA30652-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-08 7:08 ` [PATCH 1/3] irq_remap: fix compiler warning with !CONFIG_IRQ_REMAP Suresh Siddha
2012-05-08 7:08 ` Suresh Siddha
2012-05-08 10:01 ` [tip:core/iommu] irq_remap: Fix compiler warning with CONFIG_IRQ_REMAP=y tip-bot for Suresh Siddha
2012-05-08 7:08 ` [PATCH 2/3] irq_remap: fix the UP build failure Suresh Siddha
2012-05-08 7:08 ` Suresh Siddha
2012-05-08 9:09 ` Ingo Molnar
[not found] ` <20120508090945.GC27323-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-09 2:37 ` Suresh Siddha
2012-05-09 2:37 ` Suresh Siddha
2012-05-09 9:30 ` Ingo Molnar
2012-05-09 9:30 ` Ingo Molnar
2012-05-09 18:46 ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Suresh Siddha
2012-05-09 18:46 ` [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP Suresh Siddha
2012-05-09 19:58 ` Suresh Siddha
2012-05-10 7:50 ` Ingo Molnar
2012-05-10 18:19 ` Suresh Siddha
2012-06-06 23:29 ` [patch] " Suresh Siddha
2012-06-07 1:36 ` Yinghai Lu
2012-06-07 20:31 ` Suresh Siddha
2012-06-07 20:36 ` Yinghai Lu
2012-06-07 20:56 ` Suresh Siddha
2012-06-07 13:03 ` Paul Gortmaker
2012-06-07 22:34 ` Suresh Siddha
2012-06-15 1:28 ` [patch] irq: use config_enabled(CONFIG_SMP) " Suresh Siddha
2012-06-15 14:23 ` [tip:x86/apic] irq/apic: Use config_enabled(CONFIG_SMP) checks to clean up " tip-bot for Suresh Siddha
2012-05-09 18:56 ` [PATCH 1/2] kconfig: change config_enabled() to accept X instead of CONFIG_X Sam Ravnborg
2012-05-09 19:29 ` Suresh Siddha
2012-05-09 20:05 ` Sam Ravnborg
2012-05-10 6:05 ` Geert Uytterhoeven
2012-05-09 19:05 ` Linus Torvalds
2012-05-08 10:02 ` tip-bot for Suresh Siddha [this message]
2012-05-08 7:08 ` [PATCH 3/3] irq_remap: fix the 'sub_handle' uninitialized warning Suresh Siddha
2012-05-08 7:08 ` Suresh Siddha
2012-05-08 9:15 ` Ingo Molnar
2012-05-08 10:03 ` [tip:core/iommu] irq_remap: Fix " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-82b481e80d8a17720b5805393684a95184cfb6bb@git.kernel.org \
--to=suresh.b.siddha@intel.com \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.