All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Cody P Schafer <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org,
	eranian@google.com, hbabu@us.ibm.com, hpa@zytor.com,
	mingo@kernel.org, michaele@au1.ibm.com, cody@linux.vnet.ibm.com,
	peterz@infradead.org, khandual@linux.vnet.ibm.com,
	jolsa@redhat.com, dev@codyps.com, ak@linux.intel.com,
	sukadev@linux.vnet.ibm.com, tglx@linutronix.de
Subject: [tip:perf/core] perf tools: Annotate PMU related list_head members with type info
Date: Mon, 18 Aug 2014 01:22:18 -0700	[thread overview]
Message-ID: <tip-885b5930d6632fc7df55445d9021b87d8bb17a9b@git.kernel.org> (raw)
In-Reply-To: <1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.com>

Commit-ID:  885b5930d6632fc7df55445d9021b87d8bb17a9b
Gitweb:     http://git.kernel.org/tip/885b5930d6632fc7df55445d9021b87d8bb17a9b
Author:     Cody P Schafer <dev@codyps.com>
AuthorDate: Fri, 15 Aug 2014 00:26:14 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Aug 2014 10:42:40 -0300

perf tools: Annotate PMU related list_head members with type info

So that we can more readily understand in which list heads structs are
stored into.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Haren Myneni <hbabu@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Ellerman <michaele@au1.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/pmu.c | 4 ++--
 tools/perf/util/pmu.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 7a811eb..9bf5827 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -14,8 +14,8 @@
 
 struct perf_pmu_alias {
 	char *name;
-	struct list_head terms;
-	struct list_head list;
+	struct list_head terms; /* HEAD struct parse_events_term -> list */
+	struct list_head list;  /* ELEM */
 	char unit[UNIT_MAX_LEN+1];
 	double scale;
 };
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index c14a543..1c1e2ee 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -17,9 +17,9 @@ struct perf_pmu {
 	char *name;
 	__u32 type;
 	struct cpu_map *cpus;
-	struct list_head format;
-	struct list_head aliases;
-	struct list_head list;
+	struct list_head format;  /* HEAD struct perf_pmu_format -> list */
+	struct list_head aliases; /* HEAD struct perf_pmu_alias -> list */
+	struct list_head list;    /* ELEM */
 };
 
 struct perf_pmu *perf_pmu__find(const char *name);

  parent reply	other threads:[~2014-08-18  8:24 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15  7:26 [PATCH v2 00/14] Add support for parameterized events from sysfs Sukadev Bhattiprolu
2014-08-15  7:26 ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 01/14] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 03/14] perf Documentation: sysfs events/ interfaces Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 04/14] perf Documentation: remove duplicated docs for powerpc cpu specific events Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 04/14] perf Documentation: add event parameters Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 05/14] tools/perf: annotate list_head with type info Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15 13:47   ` Arnaldo Carvalho de Melo
2014-08-15 13:47     ` Arnaldo Carvalho de Melo
2014-08-18  8:22   ` tip-bot for Cody P Schafer [this message]
2014-08-15  7:26 ` [PATCH v2 06/14] tools/perf: support parsing parameterized events Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 07/14] tools/perf: extend format_alias() to include event parameters Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 08/14] tools/perf: document parameterized events and note symbolically formed events Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 09/14] perf: provide sysfs_show for struct perf_pmu_events_attr Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 10/14] powerpc/perf/hv-24x7: parse catalog and populate sysfs with events Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 11/14] powerpc/perf/hv-24x7: Documentaion for new sysfs entries which expose descriptions Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 12/14] perf: add PMU_EVENT_ATTR_STRING() helper Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 13/14] powerpc/perf/{hv-gpci, hv-common}: generate requests with counters annotated Sukadev Bhattiprolu
2014-08-15  7:26   ` [PATCH v2 13/14] powerpc/perf/{hv-gpci,hv-common}: " Sukadev Bhattiprolu
2014-08-15  7:26 ` [PATCH v2 14/14] powerpc/perf/hv-gpci: add the remaining gpci requests Sukadev Bhattiprolu
2014-08-15  7:26   ` Sukadev Bhattiprolu
2014-08-15  7:44 ` [PATCH v2 00/14] Add support for parameterized events from sysfs Peter Zijlstra
2014-08-15  7:44   ` Peter Zijlstra
2014-08-20 14:15 ` Jiri Olsa
2014-08-20 14:15   ` Jiri Olsa
2014-08-23  0:23   ` Sukadev Bhattiprolu
2014-08-23  0:23     ` Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-885b5930d6632fc7df55445d9021b87d8bb17a9b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=cody@linux.vnet.ibm.com \
    --cc=dev@codyps.com \
    --cc=eranian@google.com \
    --cc=hbabu@us.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=michaele@au1.ibm.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.