From: tip-bot for Morten Rasmussen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: torvalds@linux-foundation.org, hpa@zytor.com,
morten.rasmussen@arm.com, peterz@infradead.org,
tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: [tip:sched/core] sched/fair: Fix incorrect comment for capacity_margin
Date: Wed, 16 Nov 2016 04:14:39 -0800 [thread overview]
Message-ID: <tip-893c5d2279041afeb593f1fa8edd9d02edf5b7cb@git.kernel.org> (raw)
In-Reply-To: <1476452472-24740-7-git-send-email-morten.rasmussen@arm.com>
Commit-ID: 893c5d2279041afeb593f1fa8edd9d02edf5b7cb
Gitweb: http://git.kernel.org/tip/893c5d2279041afeb593f1fa8edd9d02edf5b7cb
Author: Morten Rasmussen <morten.rasmussen@arm.com>
AuthorDate: Fri, 14 Oct 2016 14:41:12 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 16 Nov 2016 10:29:07 +0100
sched/fair: Fix incorrect comment for capacity_margin
The comment for capacity_margin introduced in:
3273163c6775 ("sched/fair: Let asymmetric CPU configurations balance at wake-up")
... got its usage the wrong way round - fix it.
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dietmar.eggemann@arm.com
Cc: freedom.tan@mediatek.com
Cc: keita.kobayashi.ym@renesas.com
Cc: mgalbraith@suse.de
Cc: sgurrappadi@nvidia.com
Cc: vincent.guittot@linaro.org
Cc: yuyang.du@intel.com
Link: http://lkml.kernel.org/r/1476452472-24740-7-git-send-email-morten.rasmussen@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ee39bfd..5e6c00a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -109,7 +109,7 @@ unsigned int sysctl_sched_cfs_bandwidth_slice = 5000UL;
/*
* The margin used when comparing utilization with CPU capacity:
- * util * 1024 < capacity * margin
+ * util * margin < capacity * 1024
*/
unsigned int capacity_margin = 1280; /* ~20% */
prev parent reply other threads:[~2016-11-16 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 13:41 [PATCH v5 0/6] sched: Clean-ups and asymmetric cpu capacity support Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 1/6] sched/fair: Compute task/cpu utilization at wake-up correctly Morten Rasmussen
2016-11-16 12:12 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 2/6] sched/fair: Consider spare capacity in find_idlest_group() Morten Rasmussen
2016-11-16 12:13 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 3/6] sched: Add per-cpu min capacity to sched_group_capacity Morten Rasmussen
2016-11-16 12:13 ` [tip:sched/core] sched/fair: Add per-CPU " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 4/6] sched/fair: Avoid pulling tasks from non-overloaded higher capacity groups Morten Rasmussen
2016-11-16 12:14 ` [tip:sched/core] " tip-bot for Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 5/6] sched/fair: Track peak per-entity utilization Morten Rasmussen
2016-10-17 8:51 ` Morten Rasmussen
2016-10-14 13:41 ` [PATCH v5 6/6] sched/fair: Fix wrong comment for capacity_margin Morten Rasmussen
2016-11-16 12:14 ` tip-bot for Morten Rasmussen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-893c5d2279041afeb593f1fa8edd9d02edf5b7cb@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.