From: tip-bot for Suresh Siddha <suresh.b.siddha@intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vatsa@linux.vnet.ibm.com,
hpa@zytor.com, mingo@redhat.com, a.p.zijlstra@chello.nl,
suresh.b.siddha@intel.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/core] sched, nohz: Fix the idle cpu check in nohz_idle_balance
Date: Tue, 6 Dec 2011 12:24:09 -0800 [thread overview]
Message-ID: <tip-8a6d42d1b32ad239c28f445138ea9c19aa52dd20@git.kernel.org> (raw)
In-Reply-To: <1323199177.1984.12.camel@sbsiddha-desk.sc.intel.com>
Commit-ID: 8a6d42d1b32ad239c28f445138ea9c19aa52dd20
Gitweb: http://git.kernel.org/tip/8a6d42d1b32ad239c28f445138ea9c19aa52dd20
Author: Suresh Siddha <suresh.b.siddha@intel.com>
AuthorDate: Tue, 6 Dec 2011 11:19:37 -0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 6 Dec 2011 20:51:27 +0100
sched, nohz: Fix the idle cpu check in nohz_idle_balance
cpu bit in the nohz.idle_cpu_mask are reset in the first busy tick after
exiting idle. So during nohz_idle_balance(), intention is to double
check if the cpu that is part of the idle_cpu_mask is indeed idle before
going ahead in performing idle balance for that cpu.
Fix the cpu typo in the idle_cpu() check during nohz_idle_balance().
Reported-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1323199177.1984.12.camel@sbsiddha-desk.sc.intel.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched/fair.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4174338..8be45ed 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5020,7 +5020,7 @@ static void nohz_idle_balance(int this_cpu, enum cpu_idle_type idle)
goto end;
for_each_cpu(balance_cpu, nohz.idle_cpus_mask) {
- if (balance_cpu == this_cpu || !idle_cpu(this_cpu))
+ if (balance_cpu == this_cpu || !idle_cpu(balance_cpu))
continue;
/*
next prev parent reply other threads:[~2011-12-06 20:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 1:07 [patch v3 0/6] nohz idle load balancing patches Suresh Siddha
2011-12-02 1:07 ` [patch v3 1/6] sched, nohz: introduce nohz_flags in the struct rq Suresh Siddha
2011-12-06 9:53 ` [tip:sched/core] sched, nohz: Introduce nohz_flags in 'struct rq' tip-bot for Suresh Siddha
2011-12-06 12:14 ` [patch v3 1/6] sched, nohz: introduce nohz_flags in the struct rq Srivatsa Vaddagiri
2011-12-06 19:26 ` Suresh Siddha
2011-12-06 19:39 ` Peter Zijlstra
2011-12-06 20:24 ` [tip:sched/core] sched, nohz: Set the NOHZ_BALANCE_KICK flag for idle load balancer tip-bot for Suresh Siddha
2011-12-02 1:07 ` [patch v3 2/6] sched, nohz: track nr_busy_cpus in the sched_group_power Suresh Siddha
2011-12-06 9:54 ` [tip:sched/core] sched, nohz: Track " tip-bot for Suresh Siddha
2011-12-02 1:07 ` [patch v3 3/6] sched, nohz: sched group, domain aware nohz idle load balancing Suresh Siddha
2011-12-06 6:37 ` Srivatsa Vaddagiri
2011-12-06 19:19 ` Suresh Siddha
2011-12-06 20:24 ` tip-bot for Suresh Siddha [this message]
[not found] ` <A75BCAD09CE00A4280CDD4429D85F1F9261B42A1F9@orsmsx501.amr.corp.intel.com>
2011-12-06 19:27 ` Suresh Siddha
2011-12-06 9:54 ` [tip:sched/core] sched, nohz: Implement " tip-bot for Suresh Siddha
2011-12-02 1:07 ` [patch v3 4/6] sched, nohz: cleanup the find_new_ilb() using sched groups nr_busy_cpus Suresh Siddha
2011-12-06 9:55 ` [tip:sched/core] sched, nohz: Clean up " tip-bot for Suresh Siddha
2011-12-02 1:07 ` [patch v3 5/6] sched, ttwu_queue: queue remote wakeups only when crossing cache domains Suresh Siddha
2011-12-02 3:34 ` Mike Galbraith
2011-12-07 16:23 ` Peter Zijlstra
2011-12-07 19:20 ` Suresh Siddha
2011-12-08 6:06 ` Mike Galbraith
2011-12-08 9:41 ` Peter Zijlstra
2011-12-08 9:29 ` Peter Zijlstra
2011-12-08 19:34 ` Suresh Siddha
2011-12-08 21:50 ` Peter Zijlstra
2011-12-08 21:51 ` Peter Zijlstra
2011-12-08 10:02 ` Peter Zijlstra
2011-12-21 11:41 ` [tip:sched/core] sched: Only queue remote wakeups when crossing cache boundaries tip-bot for Peter Zijlstra
2011-12-02 1:07 ` [patch v3 6/6] sched: fix the sched group node allocation for SD_OVERLAP domain Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8a6d42d1b32ad239c28f445138ea9c19aa52dd20@git.kernel.org \
--to=suresh.b.siddha@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.