From: tip-bot for Ulrich Drepper <drepper@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
masami.hiramatsu.pt@hitachi.com, drepper@gmail.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:perf/urgent] x86/kprobes: Fix typo transferred from Intel manual
Date: Mon, 16 Jan 2012 01:02:17 -0800 [thread overview]
Message-ID: <tip-8d973b624ece3b85cfae9474935795d034f72faf@git.kernel.org> (raw)
In-Reply-To: <CAOPLpQfytPyDEBF1Hbkpo7ovUerEsstVGxBr=EpDL-BKEMaqLA@mail.gmail.com>
Commit-ID: 8d973b624ece3b85cfae9474935795d034f72faf
Gitweb: http://git.kernel.org/tip/8d973b624ece3b85cfae9474935795d034f72faf
Author: Ulrich Drepper <drepper@gmail.com>
AuthorDate: Sun, 15 Jan 2012 19:40:24 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 16 Jan 2012 08:20:36 +0100
x86/kprobes: Fix typo transferred from Intel manual
The arch/x86/lib/x86-opcode-map.txt file [used by the
kprobes instruction decoder] contains the line:
af: SCAS/W/D/Q rAX,Xv
This is what the Intel manuals show, but it's not correct.
The 'X' stands for:
Memory addressed by the DS:rSI register pair (for example, MOVS, CMPS, OUTS, or LODS).
On the other hand 'Y' means (also see the ae byte entry for
SCASB):
Memory addressed by the ES:rDI register pair (for example, MOVS, CMPS, INS, STOS, or SCAS).
Signed-off-by: Ulrich Drepper <drepper@gmail.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/CAOPLpQfytPyDEBF1Hbkpo7ovUerEsstVGxBr%3DEpDL-BKEMaqLA@mail.gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/lib/x86-opcode-map.txt | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt
index a793da5..8641bbb 100644
--- a/arch/x86/lib/x86-opcode-map.txt
+++ b/arch/x86/lib/x86-opcode-map.txt
@@ -210,7 +210,9 @@ ab: STOS/W/D/Q Yv,rAX
ac: LODS/B AL,Xb
ad: LODS/W/D/Q rAX,Xv
ae: SCAS/B AL,Yb
-af: SCAS/W/D/Q rAX,Xv
+# Note: The May 2011 Intel manual shows Xv for the second parameter of the
+# next instruction but Yv is correct
+af: SCAS/W/D/Q rAX,Yv
# 0xb0 - 0xbf
b0: MOV AL/R8L,Ib
b1: MOV CL/R9L,Ib
prev parent reply other threads:[~2012-01-16 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 22:24 Typo transferred from Intel manual Ulrich Drepper
2012-01-16 0:28 ` Masami Hiramatsu
2012-01-16 0:31 ` Masami Hiramatsu
2012-01-16 0:40 ` Ulrich Drepper
2012-01-16 8:41 ` Masami Hiramatsu
2012-01-16 9:02 ` tip-bot for Ulrich Drepper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8d973b624ece3b85cfae9474935795d034f72faf@git.kernel.org \
--to=drepper@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.