All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for K. Y. Srinivasan" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	kys@microsoft.com, tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/hyperv] x86, hyperv: When on Hyper-v use NULL legacy PIC
Date: Thu, 3 Apr 2014 22:15:38 -0700	[thread overview]
Message-ID: <tip-8df28b82ff0649dd293f0469b97792cfb9ed10ab@git.kernel.org> (raw)
In-Reply-To: <1396574193-12043-1-git-send-email-kys@microsoft.com>

Commit-ID:  8df28b82ff0649dd293f0469b97792cfb9ed10ab
Gitweb:     http://git.kernel.org/tip/8df28b82ff0649dd293f0469b97792cfb9ed10ab
Author:     K. Y. Srinivasan <kys@microsoft.com>
AuthorDate: Thu, 3 Apr 2014 18:16:33 -0700
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Thu, 3 Apr 2014 22:00:13 -0700

x86, hyperv: When on Hyper-v use NULL legacy PIC

Use the NULL legacy PIC when on Hyper-V. With this change we can support kexec
even when booting on EFI firmware. This patch has been tested on both EFI as
well as non-EFI firmware stacks on Hyper-V.

This patch is required to support kexec on EFI firmware on Hyper-V. Please
apply.

[ hpa: HyperV in EFI mode doesn't include a legacy PIC, and apparently
doesn't stub it out in a meaningful way.  This becomes an issue
after kexec if the second kernel doesn't know it is EFI-booted.
Since HyperV presumably never actually *needs* the legacy PIC, we
can just disable it. ]

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Link: http://lkml.kernel.org/r/1396574193-12043-1-git-send-email-kys@microsoft.com
Cc: <stable@vger.kernel.org>        [3.13+]
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/cpu/mshyperv.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 832d05a..b7d82c7 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -93,14 +93,8 @@ static void __init ms_hyperv_init_platform(void)
 		printk(KERN_INFO "HyperV: LAPIC Timer Frequency: %#x\n",
 				lapic_timer_frequency);
 
-		/*
-		 * On Hyper-V, when we are booting off an EFI firmware stack,
-		 * we do not have many legacy devices including PIC, PIT etc.
-		 */
-		if (efi_enabled(EFI_BOOT)) {
-			printk(KERN_INFO "HyperV: Using null_legacy_pic\n");
-			legacy_pic = &null_legacy_pic;
-		}
+		printk(KERN_INFO "HyperV: Using null_legacy_pic\n");
+		legacy_pic = &null_legacy_pic;
 	}
 #endif
 

  reply	other threads:[~2014-04-04  5:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  1:16 [PATCH 1/1] x86/platform/hyperv: When on Hyper-v use NULL legacy PIC K. Y. Srinivasan
2014-04-04  5:15 ` tip-bot for K. Y. Srinivasan [this message]
2014-04-04 14:12 ` Vivek Goyal
2014-04-04 15:01   ` KY Srinivasan
2014-04-04 15:16     ` Vivek Goyal
2014-04-04 20:09       ` KY Srinivasan
2014-04-04 20:32         ` Vivek Goyal
2014-04-04 22:53           ` KY Srinivasan
2014-04-07  7:06 ` Olaf Hering
2014-04-07 15:40   ` KY Srinivasan
2014-04-07 15:40     ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8df28b82ff0649dd293f0469b97792cfb9ed10ab@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.