All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Kees Cook <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
	sre@kernel.org, pmladek@suse.com, jejb@linux.vnet.ibm.com,
	gregkh@linuxfoundation.org, stefanr@s5r6.in-berlin.de,
	tglx@linutronix.de, akpm@linux-foundation.org,
	sudipm.mukherjee@gmail.com, ralf@linux-mips.org,
	rjw@rjwysocki.net, kvalo@qca.qualcomm.com, oleg@redhat.com,
	heiko.carstens@de.ibm.com, geert@linux-m68k.org,
	martin.petersen@oracle.com, john.stultz@linaro.org,
	viresh.kumar@linaro.org, arnd@arndb.de, paulus@samba.org,
	sboyd@codeaurora.org, mpe@ellerman.id.au, jiangshanlai@gmail.com,
	harish.patil@cavium.com, linux-kernel@vger.kernel.org,
	tj@kernel.org, mdr@sgi.com, manish.chopra@cavium.com,
	mingo@kernel.org, mark.gross@intel.com, cmetcalf@mellanox.com,
	wim@iguana.be, keescook@chromium.org, benh@kernel.crashing.org,
	pavel@ucw.cz, hpa@zytor.com, schwidefsky@de.ibm.com,
	len.brown@intel.com, linux@roeck-us.net
Subject: [tip:timers/core] timer: Remove expires argument from __TIMER_INITIALIZER()
Date: Thu, 5 Oct 2017 06:07:48 -0700	[thread overview]
Message-ID: <tip-8ede369b2cccfa585e2969bbed18edc0e2a18c50@git.kernel.org> (raw)
In-Reply-To: <1507159627-127660-12-git-send-email-keescook@chromium.org>

Commit-ID:  8ede369b2cccfa585e2969bbed18edc0e2a18c50
Gitweb:     https://git.kernel.org/tip/8ede369b2cccfa585e2969bbed18edc0e2a18c50
Author:     Kees Cook <keescook@chromium.org>
AuthorDate: Wed, 4 Oct 2017 16:27:05 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 5 Oct 2017 15:01:21 +0200

timer: Remove expires argument from __TIMER_INITIALIZER()

The expires field is normally initialized during the first mod_timer()
call. It was unused by all callers, so remove it from the macro.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: linux-mips@linux-mips.org
Cc: Petr Mladek <pmladek@suse.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux1394-devel@lists.sourceforge.net
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: linux-s390@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Ursula Braun <ubraun@linux.vnet.ibm.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Harish Patil <harish.patil@cavium.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Reed <mdr@sgi.com>
Cc: Manish Chopra <manish.chopra@cavium.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pm@vger.kernel.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Mark Gross <mark.gross@intel.com>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: netdev@vger.kernel.org
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lkml.kernel.org/r/1507159627-127660-12-git-send-email-keescook@chromium.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 include/linux/kthread.h   | 2 +-
 include/linux/timer.h     | 5 ++---
 include/linux/workqueue.h | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/linux/kthread.h b/include/linux/kthread.h
index 82e197e..0d622b3 100644
--- a/include/linux/kthread.h
+++ b/include/linux/kthread.h
@@ -117,7 +117,7 @@ struct kthread_delayed_work {
 #define KTHREAD_DELAYED_WORK_INIT(dwork, fn) {				\
 	.work = KTHREAD_WORK_INIT((dwork).work, (fn)),			\
 	.timer = __TIMER_INITIALIZER(kthread_delayed_work_timer_fn,	\
-				     0, (unsigned long)&(dwork),	\
+				     (unsigned long)&(dwork),		\
 				     TIMER_IRQSAFE),			\
 	}
 
diff --git a/include/linux/timer.h b/include/linux/timer.h
index 91e5a2c..10685c3 100644
--- a/include/linux/timer.h
+++ b/include/linux/timer.h
@@ -63,10 +63,9 @@ struct timer_list {
 
 #define TIMER_TRACE_FLAGMASK	(TIMER_MIGRATING | TIMER_DEFERRABLE | TIMER_PINNED | TIMER_IRQSAFE)
 
-#define __TIMER_INITIALIZER(_function, _expires, _data, _flags) { \
+#define __TIMER_INITIALIZER(_function, _data, _flags) {		\
 		.entry = { .next = TIMER_ENTRY_STATIC },	\
 		.function = (_function),			\
-		.expires = (_expires),				\
 		.data = (_data),				\
 		.flags = (_flags),				\
 		__TIMER_LOCKDEP_MAP_INITIALIZER(		\
@@ -75,7 +74,7 @@ struct timer_list {
 
 #define DEFINE_TIMER(_name, _function)				\
 	struct timer_list _name =				\
-		__TIMER_INITIALIZER(_function, 0, 0, 0)
+		__TIMER_INITIALIZER(_function, 0, 0)
 
 void init_timer_key(struct timer_list *timer, unsigned int flags,
 		    const char *name, struct lock_class_key *key);
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 1c49431..f496026 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -176,7 +176,7 @@ struct execute_work {
 #define __DELAYED_WORK_INITIALIZER(n, f, tflags) {			\
 	.work = __WORK_INITIALIZER((n).work, (f)),			\
 	.timer = __TIMER_INITIALIZER(delayed_work_timer_fn,		\
-				     0, (unsigned long)&(n),		\
+				     (unsigned long)&(n),		\
 				     (tflags) | TIMER_IRQSAFE),		\
 	}
 

  reply	other threads:[~2017-10-05 13:31 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 23:26 [PATCH 00/13] timer: Start conversion to timer_setup() Kees Cook
2017-10-04 23:26 ` Kees Cook
2017-10-04 23:26 ` Kees Cook
2017-10-04 23:26 ` [PATCH 01/13] timer: Convert schedule_timeout() to use from_timer() Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-05 13:03   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:26 ` [PATCH 02/13] timer: Remove init_timer_pinned_deferrable() in favor of timer_setup() Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-05 13:04   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:26 ` [PATCH 03/13] timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack() Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-05 13:04   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-05 13:18   ` [PATCH 03/13] " Rafael J. Wysocki
2017-10-05 13:18     ` Rafael J. Wysocki
2017-10-05 13:18     ` Rafael J. Wysocki
2017-10-04 23:26 ` [PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup() Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-05  0:41   ` David Miller
2017-10-05  0:41     ` David Miller
2017-10-05 13:05   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:26 ` [PATCH 05/13] timer: Remove init_timer_deferrable() " Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-04 23:26   ` Kees Cook
2017-10-05  0:41   ` David Miller
2017-10-05  0:41     ` David Miller
2017-10-05  1:02   ` Sebastian Reichel
2017-10-05  1:02     ` Sebastian Reichel
2017-10-05 13:05   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:27 ` [PATCH 06/13] timer: Remove users of TIMER_DEFERRED_INITIALIZER Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:05   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:27 ` [PATCH 07/13] timer: Remove last user of TIMER_INITIALIZER Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:06   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-05 22:39   ` [PATCH 07/13] " Gross, Mark
2017-10-05 22:39     ` Gross, Mark
2017-10-05 22:39     ` Gross, Mark
2017-10-05 22:39     ` Gross, Mark
2017-10-04 23:27 ` [PATCH 08/13] timer: Remove unused static initializer macros Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:06   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-04 23:27 ` [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05  0:12   ` Guenter Roeck
2017-10-05  0:12     ` Guenter Roeck
2017-10-05  0:12     ` Guenter Roeck
2017-10-05 13:07   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-09 13:23   ` [PATCH 09/13] " Ralf Baechle
2017-10-09 13:23     ` Ralf Baechle
2017-10-04 23:27 ` [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05  0:13   ` Guenter Roeck
2017-10-05  0:13     ` Guenter Roeck
2017-10-05  0:13     ` Guenter Roeck
2017-10-05  0:40   ` David Miller
2017-10-05  0:40     ` David Miller
2017-10-05  5:28   ` Greg Kroah-Hartman
2017-10-05  5:28     ` Greg Kroah-Hartman
2017-10-05  5:28     ` Greg Kroah-Hartman
2017-10-05  6:54   ` Kalle Valo
2017-10-05  6:54     ` Kalle Valo
2017-10-05  6:54     ` Kalle Valo
2017-10-05  8:59   ` Arnd Bergmann
2017-10-05  8:59     ` Arnd Bergmann
2017-10-05  8:59     ` Arnd Bergmann
2017-10-05 13:07   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-09 13:27   ` [PATCH 10/13] " Ralf Baechle
2017-10-09 13:27     ` Ralf Baechle
2017-10-04 23:27 ` [PATCH 11/13] timer: Remove expires argument from __TIMER_INITIALIZER() Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:07   ` tip-bot for Kees Cook [this message]
2017-10-11 10:15   ` Petr Mladek
2017-10-11 10:15     ` Petr Mladek
2017-10-04 23:27 ` [PATCH 12/13] kthread: Convert callback to use from_timer() Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:08   ` [tip:timers/core] " tip-bot for Kees Cook
2017-10-11 10:20   ` [PATCH 12/13] " Petr Mladek
2017-10-11 10:20     ` Petr Mladek
2017-10-11 10:20     ` Petr Mladek
2017-10-04 23:27 ` [PATCH 13/13] workqueue: " Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-04 23:27   ` Kees Cook
2017-10-05 13:08   ` [tip:timers/core] " tip-bot for Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8ede369b2cccfa585e2969bbed18edc0e2a18c50@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=cmetcalf@mellanox.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=harish.patil@cavium.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=jwi@linux.vnet.ibm.com \
    --cc=keescook@chromium.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=manish.chopra@cavium.com \
    --cc=mark.gross@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=mdr@sgi.com \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=oleg@redhat.com \
    --cc=paulus@samba.org \
    --cc=pavel@ucw.cz \
    --cc=pmladek@suse.com \
    --cc=ralf@linux-mips.org \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sre@kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=ubraun@linux.vnet.ibm.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.