All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Paul Gortmaker <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, paul.gortmaker@windriver.com,
	mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
	torvalds@linux-foundation.org, tglx@linutronix.de
Subject: [tip:x86/mm] x86/mm/pat: Make mm/pageattr[-test] .c explicitly non-modular
Date: Tue, 25 Aug 2015 01:22:20 -0700	[thread overview]
Message-ID: <tip-8f45fe441a9836011672436ef007654969b28ccc@git.kernel.org> (raw)
In-Reply-To: <1440459295-21814-3-git-send-email-paul.gortmaker@windriver.com>

Commit-ID:  8f45fe441a9836011672436ef007654969b28ccc
Gitweb:     http://git.kernel.org/tip/8f45fe441a9836011672436ef007654969b28ccc
Author:     Paul Gortmaker <paul.gortmaker@windriver.com>
AuthorDate: Mon, 24 Aug 2015 19:34:54 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 25 Aug 2015 09:48:38 +0200

x86/mm/pat: Make mm/pageattr[-test].c explicitly non-modular

The file pageattr.c is obj-y and it includes pageattr-test.c
based on CPA_DEBUG (a bool), meaning that no code here is
currently being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading
the code there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the
non-modular case, the init ordering remains unchanged with this
commit.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1440459295-21814-3-git-send-email-paul.gortmaker@windriver.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/mm/pageattr-test.c | 4 ++--
 arch/x86/mm/pageattr.c      | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/mm/pageattr-test.c b/arch/x86/mm/pageattr-test.c
index 8ff686a..5f169d5 100644
--- a/arch/x86/mm/pageattr-test.c
+++ b/arch/x86/mm/pageattr-test.c
@@ -8,6 +8,7 @@
 #include <linux/kthread.h>
 #include <linux/random.h>
 #include <linux/kernel.h>
+#include <linux/init.h>
 #include <linux/mm.h>
 #include <linux/vmalloc.h>
 
@@ -256,5 +257,4 @@ static int start_pageattr_test(void)
 
 	return 0;
 }
-
-module_init(start_pageattr_test);
+device_initcall(start_pageattr_test);
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 727158c..2c44c07 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -4,7 +4,6 @@
  */
 #include <linux/highmem.h>
 #include <linux/bootmem.h>
-#include <linux/module.h>
 #include <linux/sched.h>
 #include <linux/mm.h>
 #include <linux/interrupt.h>

  reply	other threads:[~2015-08-25  8:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 23:34 [PATCH 0/3] x86: fix instances of non-modular code using modular fcns Paul Gortmaker
2015-08-24 23:34 ` [PATCH 1/3] x86/platform: make atom/pmc_atom.c explicitly non-modular Paul Gortmaker
2015-08-25  8:22   ` [tip:x86/platform] x86/platform: Make atom/ pmc_atom.c " tip-bot for Paul Gortmaker
2015-08-24 23:34 ` [PATCH 2/3] arch/x86: make mm/pageattr[-test].c " Paul Gortmaker
2015-08-25  8:22   ` tip-bot for Paul Gortmaker [this message]
2015-08-24 23:34 ` [PATCH 3/3] arch/x86: make kernel/check.c " Paul Gortmaker
2015-08-25  8:22   ` [tip:x86/mm] x86/mm: Make " tip-bot for Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-8f45fe441a9836011672436ef007654969b28ccc@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.