All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de, mingo@elte.hu, shmulik.ladkani@gmail.com
Subject: [tip:sched/core] sched.c: Call debug_show_all_locks() when dumping all tasks
Date: Wed, 25 Nov 2009 13:30:49 GMT	[thread overview]
Message-ID: <tip-93335a21557e80f6a99bc2812c634e488139043c@git.kernel.org> (raw)
In-Reply-To: <4b0d2fe4.0ab6660a.6437.3cfc@mx.google.com>

Commit-ID:  93335a21557e80f6a99bc2812c634e488139043c
Gitweb:     http://git.kernel.org/tip/93335a21557e80f6a99bc2812c634e488139043c
Author:     Shmulik Ladkani <shmulik.ladkani@gmail.com>
AuthorDate: Wed, 25 Nov 2009 15:23:41 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 25 Nov 2009 14:26:52 +0100

sched.c: Call debug_show_all_locks() when dumping all tasks

In commit v2.6.21-691-g39bc89f ("make SysRq-T show all tasks
again") the interface of show_state_filter() was changed: zero
valued 'state_filter' specifies "dump all tasks" (instead of -1).

However, the condition for calling debug_show_all_locks() ("show
locks if all tasks are dumped") was not updated accordingly.

Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: peterz@infradead.org
LKML-Reference: <4b0d2fe4.0ab6660a.6437.3cfc@mx.google.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 010d5e1..a57c6ae 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6915,7 +6915,7 @@ void show_state_filter(unsigned long state_filter)
 	/*
 	 * Only show locks if all tasks are dumped:
 	 */
-	if (state_filter == -1)
+	if (!state_filter)
 		debug_show_all_locks();
 }
 

      reply	other threads:[~2009-11-25 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 13:23 [PATCH] sched.c: call debug_show_all_locks when dumping all tasks Shmulik Ladkani
2009-11-25 13:30 ` tip-bot for Shmulik Ladkani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-93335a21557e80f6a99bc2812c634e488139043c@git.kernel.org \
    --to=shmulik.ladkani@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.