All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Sergio Aguirre <saaguirre@ti.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	a.p.zijlstra@chello.nl, schwidefsky@de.ibm.com, kyle@mcmartin.ca,
	ying.huang@intel.com, saaguirre@ti.com, tglx@linutronix.de,
	mingo@elte.hu
Subject: [tip:perf/urgent] irq_work: Drop cmpxchg() result
Date: Thu, 18 Nov 2010 14:09:33 GMT	[thread overview]
Message-ID: <tip-94e8ba728640dc01375a14e337f3b892bfacbeeb@git.kernel.org> (raw)
In-Reply-To: <1289930567-17828-1-git-send-email-saaguirre@ti.com>

Commit-ID:  94e8ba728640dc01375a14e337f3b892bfacbeeb
Gitweb:     http://git.kernel.org/tip/94e8ba728640dc01375a14e337f3b892bfacbeeb
Author:     Sergio Aguirre <saaguirre@ti.com>
AuthorDate: Tue, 16 Nov 2010 12:02:47 -0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 18 Nov 2010 13:18:47 +0100

irq_work: Drop cmpxchg() result

The compiler warned us about:

 kernel/irq_work.c: In function 'irq_work_run':
 kernel/irq_work.c:148: warning: value computed is not used

Dropping the cmpxchg() result is indeed weird, but correct -
so annotate away the warning.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1289930567-17828-1-git-send-email-saaguirre@ti.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/irq_work.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index f16763f..90f8819 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -145,7 +145,9 @@ void irq_work_run(void)
 		 * Clear the BUSY bit and return to the free state if
 		 * no-one else claimed it meanwhile.
 		 */
-		cmpxchg(&entry->next, next_flags(NULL, IRQ_WORK_BUSY), NULL);
+		(void)cmpxchg(&entry->next,
+			      next_flags(NULL, IRQ_WORK_BUSY),
+			      NULL);
 	}
 }
 EXPORT_SYMBOL_GPL(irq_work_run);

      parent reply	other threads:[~2010-11-18 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 18:02 [RFC][PATCH v2] irq_work: Drop cmpxchg result Sergio Aguirre
2010-11-16 18:16 ` Eric Dumazet
2010-11-16 19:32   ` Aguirre, Sergio
2010-11-16 18:26 ` Peter Zijlstra
2010-11-18 14:09 ` tip-bot for Sergio Aguirre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-94e8ba728640dc01375a14e337f3b892bfacbeeb@git.kernel.org \
    --to=saaguirre@ti.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.