From: "tip-bot for H. Peter Anvin" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
tglx@linutronix.de, prarit@redhat.com, hpa@linux.intel.com
Subject: [tip:x86/urgent] x86, irq: Change check_vectors() to check_irq_vectors_for_cpu_disable()
Date: Fri, 20 Dec 2013 15:39:33 -0800 [thread overview]
Message-ID: <tip-9d69bb2cd96221b35bcabb3c1ffe84160bcf1b9f@git.kernel.org> (raw)
In-Reply-To: <1387554609-9823-1-git-send-email-prarit@redhat.com>
Commit-ID: 9d69bb2cd96221b35bcabb3c1ffe84160bcf1b9f
Gitweb: http://git.kernel.org/tip/9d69bb2cd96221b35bcabb3c1ffe84160bcf1b9f
Author: H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Fri, 20 Dec 2013 15:34:22 -0800
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Fri, 20 Dec 2013 15:34:22 -0800
x86, irq: Change check_vectors() to check_irq_vectors_for_cpu_disable()
In the context of smpboot.c especially, it is not at all obvious what
"check_vectors" actually mean. Since this function is only called in
one place, without arguments, we can afford to be a bit more verbose
with the function name and make it clear at a glance what the function
does.
Cc: Prarit Bhargava <prarit@redhat.com>
Link: http://lkml.kernel.org/r/1387554609-9823-1-git-send-email-prarit@redhat.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/include/asm/irq.h | 2 +-
arch/x86/kernel/irq.c | 2 +-
arch/x86/kernel/smpboot.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/irq.h b/arch/x86/include/asm/irq.h
index dfd7372..cb6cfcd 100644
--- a/arch/x86/include/asm/irq.h
+++ b/arch/x86/include/asm/irq.h
@@ -25,7 +25,7 @@ extern void irq_ctx_init(int cpu);
#ifdef CONFIG_HOTPLUG_CPU
#include <linux/cpumask.h>
-extern int check_vectors(void);
+extern int check_irq_vectors_for_cpu_disable(void);
extern void fixup_irqs(void);
extern void irq_force_complete_move(int);
#endif
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 483f111..7d40698 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -266,7 +266,7 @@ EXPORT_SYMBOL_GPL(vector_used_by_percpu_irq);
* This cpu is going to be removed and its vectors migrated to the remaining
* online cpus. Check to see if there are enough vectors in the remaining cpus.
*/
-int check_vectors(void)
+int check_irq_vectors_for_cpu_disable(void)
{
int irq, cpu;
unsigned int vector, this_count, count;
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 7ac6654..391ea52 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1314,7 +1314,7 @@ int native_cpu_disable(void)
{
int ret;
- ret = check_vectors();
+ ret = check_irq_vectors_for_cpu_disable();
if (ret)
return ret;
next prev parent reply other threads:[~2013-12-20 23:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 15:50 [PATCH] x86: Add check for number of available vectors before CPU down [v3] Prarit Bhargava
2013-12-20 22:56 ` Andi Kleen
2013-12-20 23:06 ` Luck, Tony
2013-12-21 0:08 ` H. Peter Anvin
2013-12-20 23:39 ` [tip:x86/urgent] x86: Add check for number of available vectors before CPU down tip-bot for Prarit Bhargava
2013-12-20 23:39 ` tip-bot for H. Peter Anvin [this message]
2013-12-23 7:12 ` [PATCH] x86: Add check for number of available vectors before CPU down [v3] Chen, Gong
2013-12-23 12:32 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9d69bb2cd96221b35bcabb3c1ffe84160bcf1b9f@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.