From: tip-bot for Ben Hutchings <ben@decadent.org.uk>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
debian-kernel@lists.debian.org, nbowler@elliptictech.com,
hpa@zytor.com, mingo@redhat.com, rusty@rustcorp.com.au,
peterz@infradead.org, greg@kroah.com, rdunlap@xenotime.net,
davej@redhat.com, ben@decadent.org.uk, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:core/locking] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging
Date: Wed, 7 Dec 2011 20:37:11 -0800 [thread overview]
Message-ID: <tip-9ec84acee1e221d99dc33237bff5e82839d10cc0@git.kernel.org> (raw)
In-Reply-To: <1323268258.18450.11.camel@deadeye>
Commit-ID: 9ec84acee1e221d99dc33237bff5e82839d10cc0
Gitweb: http://git.kernel.org/tip/9ec84acee1e221d99dc33237bff5e82839d10cc0
Author: Ben Hutchings <ben@decadent.org.uk>
AuthorDate: Wed, 7 Dec 2011 14:30:58 +0000
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 7 Dec 2011 23:32:10 +0100
lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging
We do want to allow lock debugging for GPL-compatible modules
that are not (yet) built in-tree. This was disabled as a
side-effect of commit 2449b8ba0745327c5fa49a8d9acffe03b2eded69
('module,bug: Add TAINT_OOT_MODULE flag for modules not built
in-tree'). Lock debug warnings now include taint flags, so
kernel developers should still be able to deflect warnings
caused by out-of-tree modules.
The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules
will still disable lock debugging.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Nick Bowler <nbowler@elliptictech.com>
Cc: Greg KH <greg@kroah.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Debian kernel maintainers <debian-kernel@lists.debian.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/1323268258.18450.11.camel@deadeye
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/panic.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index 1b83fd8..3458469 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -237,11 +237,12 @@ void add_taint(unsigned flag)
* Can't trust the integrity of the kernel anymore.
* We don't call directly debug_locks_off() because the issue
* is not necessarily serious enough to set oops_in_progress to 1
- * Also we want to keep up lockdep for staging development and
- * post-warning case.
+ * Also we want to keep up lockdep for staging/out-of-tree
+ * development and post-warning case.
*/
switch (flag) {
case TAINT_CRAP:
+ case TAINT_OOT_MODULE:
case TAINT_WARN:
case TAINT_FIRMWARE_WORKAROUND:
break;
prev parent reply other threads:[~2011-12-08 4:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 14:30 [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging Ben Hutchings
2011-12-08 4:30 ` Rusty Russell
2011-12-08 4:37 ` tip-bot for Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-9ec84acee1e221d99dc33237bff5e82839d10cc0@git.kernel.org \
--to=ben@decadent.org.uk \
--cc=alan@linux.intel.com \
--cc=davej@redhat.com \
--cc=debian-kernel@lists.debian.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=nbowler@elliptictech.com \
--cc=peterz@infradead.org \
--cc=rdunlap@xenotime.net \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.