From: tip-bot for Vivek Goyal <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
tglx@linutronix.de, vgoyal@redhat.com
Subject: [tip:x86/boot] x86, boot: Remove misc.h inclusion from compressed /string.c
Date: Thu, 8 May 2014 08:09:47 -0700 [thread overview]
Message-ID: <tip-a9a17104a112a67a7bf0679b734704c130eb5faa@git.kernel.org> (raw)
In-Reply-To: <1398447972-27896-3-git-send-email-vgoyal@redhat.com>
Commit-ID: a9a17104a112a67a7bf0679b734704c130eb5faa
Gitweb: http://git.kernel.org/tip/a9a17104a112a67a7bf0679b734704c130eb5faa
Author: Vivek Goyal <vgoyal@redhat.com>
AuthorDate: Fri, 25 Apr 2014 13:46:12 -0400
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 8 May 2014 08:00:06 -0700
x86, boot: Remove misc.h inclusion from compressed/string.c
Given the fact that we removed inclusion of boot.h from boot/string.c
does not look like we need misc.h inclusion in compressed/string.c. So
remove it.
misc.h was also pulling in string_32.h which in turn had macros for
memcmp and memcpy. So we don't need to #undef memcmp and memcpy anymore.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Link: http://lkml.kernel.org/r/1398447972-27896-3-git-send-email-vgoyal@redhat.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/boot/compressed/string.c | 4 ----
arch/x86/boot/string.c | 6 ------
2 files changed, 10 deletions(-)
diff --git a/arch/x86/boot/compressed/string.c b/arch/x86/boot/compressed/string.c
index f3c57e3..00e788b 100644
--- a/arch/x86/boot/compressed/string.c
+++ b/arch/x86/boot/compressed/string.c
@@ -1,9 +1,5 @@
-#include "misc.h"
#include "../string.c"
-/* misc.h might pull in string_32.h which has a macro for memcpy. undef that */
-#undef memcpy
-
#ifdef CONFIG_X86_32
void *memcpy(void *dest, const void *src, size_t n)
{
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index aca52b8..493f3fd 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -15,12 +15,6 @@
#include <linux/types.h>
#include "ctype.h"
-/*
- * This file gets included in compressed/string.c which might pull in
- * string_32.h and which in turn maps memcmp to __builtin_memcmp(). Undo
- * that first.
- */
-#undef memcmp
int memcmp(const void *s1, const void *s2, size_t len)
{
u8 diff;
next prev parent reply other threads:[~2014-05-08 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 17:46 [PATCH 0/2] x86/boot: Small string.c cleanups Vivek Goyal
2014-04-25 17:46 ` [PATCH 1/2] x86/boot: Do not include boot.h in string.c Vivek Goyal
2014-05-08 15:09 ` [tip:x86/boot] x86, boot: " tip-bot for Vivek Goyal
2014-04-25 17:46 ` [PATCH 2/2] x86/boot: Remove misc.h inclusion from compressed/string.c Vivek Goyal
2014-05-08 15:09 ` tip-bot for Vivek Goyal [this message]
2014-05-08 14:23 ` [PATCH 0/2] x86/boot: Small string.c cleanups Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-a9a17104a112a67a7bf0679b734704c130eb5faa@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.