From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044AbdHKNaA (ORCPT ); Fri, 11 Aug 2017 09:30:00 -0400 Received: from terminus.zytor.com ([65.50.211.136]:48227 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbdHKN37 (ORCPT ); Fri, 11 Aug 2017 09:29:59 -0400 Date: Fri, 11 Aug 2017 06:25:19 -0700 From: tip-bot for Arnd Bergmann Message-ID: Cc: torvalds@linux-foundation.org, icanrealizeum@gmail.com, bp@suse.de, Yazen.Ghannam@amd.com, linux-kernel@vger.kernel.org, peterz@infradead.org, thomas.lendacky@amd.com, hpa@zytor.com, arnd@arndb.de, tglx@linutronix.de, suravee.suthikulpanit@amd.com, mingo@kernel.org Reply-To: suravee.suthikulpanit@amd.com, mingo@kernel.org, tglx@linutronix.de, arnd@arndb.de, hpa@zytor.com, peterz@infradead.org, thomas.lendacky@amd.com, Yazen.Ghannam@amd.com, linux-kernel@vger.kernel.org, bp@suse.de, icanrealizeum@gmail.com, torvalds@linux-foundation.org In-Reply-To: <20170811111937.2006128-1-arnd@arndb.de> References: <20170811111937.2006128-1-arnd@arndb.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/cpu] x86/cpu/amd: Hide unused legacy_fixup_core_id() function Git-Commit-ID: aac64f7de999d5a7fff55f49434fdd87df919829 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: aac64f7de999d5a7fff55f49434fdd87df919829 Gitweb: http://git.kernel.org/tip/aac64f7de999d5a7fff55f49434fdd87df919829 Author: Arnd Bergmann AuthorDate: Fri, 11 Aug 2017 13:19:11 +0200 Committer: Ingo Molnar CommitDate: Fri, 11 Aug 2017 14:58:34 +0200 x86/cpu/amd: Hide unused legacy_fixup_core_id() function The newly introduced function is only used when CONFIG_SMP is set: arch/x86/kernel/cpu/amd.c:305:13: warning: 'legacy_fixup_core_id' defined but not used This moves the existing #ifdef around the caller so it covers legacy_fixup_core_id() as well. Signed-off-by: Arnd Bergmann Cc: Borislav Petkov Cc: Emanuel Czirai Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Suravee Suthikulpanit Cc: Thomas Gleixner Cc: Tom Lendacky Cc: Yazen Ghannam Fixes: b89b41d0b841 ("x86/cpu/amd: Limit cpu_core_id fixup to families older than F17h") Link: http://lkml.kernel.org/r/20170811111937.2006128-1-arnd@arndb.de Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 82d571c..e44338d 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -297,6 +297,7 @@ static int nearby_node(int apicid) } #endif +#ifdef CONFIG_SMP /* * Fix up cpu_core_id for pre-F17h systems to be in the * [0 .. cores_per_node - 1] range. Not really needed but @@ -319,7 +320,6 @@ static void legacy_fixup_core_id(struct cpuinfo_x86 *c) * Assumption: Number of cores in each internal node is the same. * (2) AMD processors supporting compute units */ -#ifdef CONFIG_SMP static void amd_get_topology(struct cpuinfo_x86 *c) { u8 node_id;