From: tip-bot for Nick Desaulniers <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: morbo@google.com, hpa@zytor.com, dima@golovin.in,
luto@kernel.org, maskray@google.com, mingo@redhat.com,
andi@firstfloor.org, ndesaulniers@google.com, ruiu@google.com,
mingo@kernel.org, x86@kernel.org, tglx@linutronix.de, bp@suse.de,
linux-kernel@vger.kernel.org
Subject: [tip:x86/urgent] x86/vdso: Drop implicit common-page-size linker flag
Date: Fri, 7 Dec 2018 10:33:56 -0800 [thread overview]
Message-ID: <tip-ac3e233d29f7f77f28243af0132057d378d3ea58@git.kernel.org> (raw)
In-Reply-To: <20181206191231.192355-1-ndesaulniers@google.com>
Commit-ID: ac3e233d29f7f77f28243af0132057d378d3ea58
Gitweb: https://git.kernel.org/tip/ac3e233d29f7f77f28243af0132057d378d3ea58
Author: Nick Desaulniers <ndesaulniers@google.com>
AuthorDate: Thu, 6 Dec 2018 11:12:31 -0800
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Fri, 7 Dec 2018 18:57:38 +0100
x86/vdso: Drop implicit common-page-size linker flag
GNU linker's -z common-page-size's default value is based on the target
architecture. arch/x86/entry/vdso/Makefile sets it to the architecture
default, which is implicit and redundant. Drop it.
Fixes: 2aae950b21e4 ("x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu")
Reported-by: Dmitry Golovin <dima@golovin.in>
Reported-by: Bill Wendling <morbo@google.com>
Suggested-by: Dmitry Golovin <dima@golovin.in>
Suggested-by: Rui Ueyama <ruiu@google.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Andy Lutomirski <luto@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Fangrui Song <maskray@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
Link: https://bugs.llvm.org/show_bug.cgi?id=38774
Link: https://github.com/ClangBuiltLinux/linux/issues/31
---
arch/x86/entry/vdso/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 141d415a8c80..0624bf2266fd 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -47,7 +47,7 @@ targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so)
CPPFLAGS_vdso.lds += -P -C
VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -soname linux-vdso.so.1 --no-undefined \
- -z max-page-size=4096 -z common-page-size=4096
+ -z max-page-size=4096
$(obj)/vdso64.so.dbg: $(obj)/vdso.lds $(vobjs) FORCE
$(call if_changed,vdso)
@@ -98,7 +98,7 @@ CFLAGS_REMOVE_vvar.o = -pg
CPPFLAGS_vdsox32.lds = $(CPPFLAGS_vdso.lds)
VDSO_LDFLAGS_vdsox32.lds = -m elf32_x86_64 -soname linux-vdso.so.1 \
- -z max-page-size=4096 -z common-page-size=4096
+ -z max-page-size=4096
# x32-rebranded versions
vobjx32s-y := $(vobjs-y:.o=-x32.o)
next prev parent reply other threads:[~2018-12-07 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 19:12 [PATCH] x86/vdso: drop implicit common-page-size linker flag ndesaulniers
2018-12-06 20:29 ` Andy Lutomirski
2018-12-07 10:18 ` Borislav Petkov
2018-12-07 17:45 ` Nick Desaulniers
2018-12-07 17:52 ` Borislav Petkov
2018-12-07 18:00 ` Nick Desaulniers
2018-12-07 18:33 ` tip-bot for Nick Desaulniers [this message]
2018-12-11 13:12 ` [tip:x86/build] x86/um/vdso: Drop " tip-bot for ndesaulniers@google.com
2018-12-11 17:39 ` Nick Desaulniers
2018-12-11 17:43 ` Richard Weinberger
2018-12-11 17:46 ` Borislav Petkov
2018-12-11 17:53 ` Nick Desaulniers
2018-12-11 18:05 ` Borislav Petkov
2018-12-11 19:08 ` Nick Desaulniers
2018-12-11 20:14 ` Richard Weinberger
2018-12-11 20:53 ` Borislav Petkov
2018-12-11 13:25 ` tip-bot for Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ac3e233d29f7f77f28243af0132057d378d3ea58@git.kernel.org \
--to=tipbot@zytor.com \
--cc=andi@firstfloor.org \
--cc=bp@suse.de \
--cc=dima@golovin.in \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maskray@google.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=ruiu@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.