From: "tip-bot for cpw@sgi.com" <cpw@sgi.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
cpw@sgi.com, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/uv] x86, UV: Correct UV2 BAU destination timeout
Date: Tue, 21 Jun 2011 15:19:24 GMT [thread overview]
Message-ID: <tip-ae90c232be376bd8a283f3b6fb37cb5bd2635d67@git.kernel.org> (raw)
In-Reply-To: <20110621122243.117324443@sgi.com>
Commit-ID: ae90c232be376bd8a283f3b6fb37cb5bd2635d67
Gitweb: http://git.kernel.org/tip/ae90c232be376bd8a283f3b6fb37cb5bd2635d67
Author: cpw@sgi.com <cpw@sgi.com>
AuthorDate: Tue, 21 Jun 2011 07:21:33 -0500
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 21 Jun 2011 14:50:34 +0200
x86, UV: Correct UV2 BAU destination timeout
Correct the UV2 broacast assist unit's destination timeout
period. And the activation status register in UV2 should be
tested for a destination timeout with a 4, not a 2. The values
for Active versus Timeout were reversed.
This patch is critical for TLB shootdown on an Altix UV2 system
(i.e. the follow-on to the current Altix UV).
Destination timeout period:
The period is set in 4 bits of memory-mapped register MISC_CONTROL.
The left bit toggles base period between 10us and 80us.
The other 3 bits are the multiplier.
Decimal 15, hex f, gives the maximum: 7 * 80us
Signed-off-by: Cliff Wickman <cpw@sgi.com>
Link: http://lkml.kernel.org/r/20110621122243.117324443@sgi.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/uv/uv_bau.h | 18 +++++++++++++-----
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/uv/uv_bau.h b/arch/x86/include/asm/uv/uv_bau.h
index 16ce58c..37d3698 100644
--- a/arch/x86/include/asm/uv/uv_bau.h
+++ b/arch/x86/include/asm/uv/uv_bau.h
@@ -67,7 +67,7 @@
* we're using 655us, similar to UV1: 65 units of 10us
*/
#define UV1_INTD_SOFT_ACK_TIMEOUT_PERIOD (9UL)
-#define UV2_INTD_SOFT_ACK_TIMEOUT_PERIOD (65*10UL)
+#define UV2_INTD_SOFT_ACK_TIMEOUT_PERIOD (15UL)
#define UV_INTD_SOFT_ACK_TIMEOUT_PERIOD (is_uv1_hub() ? \
UV1_INTD_SOFT_ACK_TIMEOUT_PERIOD : \
@@ -106,12 +106,20 @@
#define DS_SOURCE_TIMEOUT 3
/*
* bits put together from HRP_LB_BAU_SB_ACTIVATION_STATUS_0/1/2
- * values 1 and 5 will not occur
+ * values 1 and 3 will not occur
+ * Decoded meaning ERROR BUSY AUX ERR
+ * ------------------------------- ---- ----- -------
+ * IDLE 0 0 0
+ * BUSY (active) 0 1 0
+ * SW Ack Timeout (destination) 1 0 0
+ * SW Ack INTD rejected (strong NACK) 1 0 1
+ * Source Side Time Out Detected 1 1 0
+ * Destination Side PUT Failed 1 1 1
*/
#define UV2H_DESC_IDLE 0
-#define UV2H_DESC_DEST_TIMEOUT 2
-#define UV2H_DESC_DEST_STRONG_NACK 3
-#define UV2H_DESC_BUSY 4
+#define UV2H_DESC_BUSY 2
+#define UV2H_DESC_DEST_TIMEOUT 4
+#define UV2H_DESC_DEST_STRONG_NACK 5
#define UV2H_DESC_SOURCE_TIMEOUT 6
#define UV2H_DESC_DEST_PUT_ERR 7
prev parent reply other threads:[~2011-06-21 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 12:21 [patch 0/8 v5] Subject: x86, UV: fixes to tlb shootdown cpw
2011-06-21 12:21 ` [patch 1/8 v5] x86, UV: smp_processor_id in a preemptable region cpw
2011-06-21 15:16 ` [tip:x86/uv] x86, UV: Fix smp_processor_id() use " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 2/8 v5] x86, UV: inline header file functions cpw
2011-06-21 15:16 ` [tip:x86/uv] x86, UV: Inline " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 3/8 v5] x86, UV: allow for non-consecutive sockets cpw
2011-06-21 15:17 ` [tip:x86/uv] x86, UV: Allow " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 4/8 v5] x86, UV: correct reset_with_ipi() cpw
2011-06-21 15:17 ` [tip:x86/uv] x86, UV: Correct reset_with_ipi() tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 5/8 v5] x86, UV: rename hubmask to pnmask cpw
2011-06-21 15:18 ` [tip:x86/uv] x86, UV: Rename " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 6/8 v5] x86, UV: remove cpumask_t from the stack cpw
2011-06-21 15:18 ` [tip:x86/uv] x86, UV: Remove " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 7/8 v5] x86, UV: correct failed topology memory leak cpw
2011-06-21 15:18 ` [tip:x86/uv] x86, UV: Correct " tip-bot for cpw@sgi.com
2011-06-21 12:21 ` [patch 8/8 v5] x86, UV: correct UV2 BAU destination timeout cpw
2011-06-21 15:19 ` tip-bot for cpw@sgi.com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ae90c232be376bd8a283f3b6fb37cb5bd2635d67@git.kernel.org \
--to=cpw@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.