From: tip-bot for Masami Hiramatsu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: masami.hiramatsu.pt@hitachi.com, peterz@infradead.org,
jolsa@redhat.com, mingo@kernel.org, acme@redhat.com,
linux-kernel@vger.kernel.org, namhyung@kernel.org,
dsahern@gmail.com, tglx@linutronix.de, hpa@zytor.com
Subject: [tip:perf/core] perf probe: Make --funcs option exclusive
Date: Tue, 5 May 2015 20:06:39 -0700 [thread overview]
Message-ID: <tip-b3ac032b7a76fea678de225d26ae04d10e47f0ac@git.kernel.org> (raw)
In-Reply-To: <20150423134612.26128.58189.stgit@localhost.localdomain>
Commit-ID: b3ac032b7a76fea678de225d26ae04d10e47f0ac
Gitweb: http://git.kernel.org/tip/b3ac032b7a76fea678de225d26ae04d10e47f0ac
Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Thu, 23 Apr 2015 22:46:12 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 29 Apr 2015 10:38:02 -0300
perf probe: Make --funcs option exclusive
The --funcs option should be given exclusively. This adds
PARSE_OPT_EXCUSIVE flag on --funcs (-F) option.
Without this, 'perf probe --funcs -l' just shows the list of probes.
With this, it shows error message correctly.
This also fixes the help message and the documentation.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20150423134612.26128.58189.stgit@localhost.localdomain
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Documentation/perf-probe.txt | 2 ++
tools/perf/builtin-probe.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
index 239609c..a4a3cc7 100644
--- a/tools/perf/Documentation/perf-probe.txt
+++ b/tools/perf/Documentation/perf-probe.txt
@@ -19,6 +19,8 @@ or
'perf probe' [options] --line='LINE'
or
'perf probe' [options] --vars='PROBEPOINT'
+or
+'perf probe' [options] --funcs
DESCRIPTION
-----------
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index f7b1af6..92dcce0 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -321,6 +321,7 @@ __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
"perf probe [<options>] --line 'LINEDESC'",
"perf probe [<options>] --vars 'PROBEPOINT'",
#endif
+ "perf probe [<options>] --funcs",
NULL
};
struct option options[] = {
@@ -402,6 +403,7 @@ __cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
set_option_flag(options, 'L', "line", PARSE_OPT_EXCLUSIVE);
set_option_flag(options, 'V', "vars", PARSE_OPT_EXCLUSIVE);
#endif
+ set_option_flag(options, 'F', "funcs", PARSE_OPT_EXCLUSIVE);
argc = parse_options(argc, argv, options, probe_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
next prev parent reply other threads:[~2015-05-06 3:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 13:46 [PATCH perf/core v2 0/8] perf-probe: Add filtering features Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 1/8] [BUGFIX] perf probe: Make --funcs option exclusive Masami Hiramatsu
2015-05-06 3:06 ` tip-bot for Masami Hiramatsu [this message]
2015-04-23 13:46 ` [PATCH perf/core v2 2/8] [BUGFIX] perf probe: Remove all probes matches given pattern at once Masami Hiramatsu
2015-05-06 3:06 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 3/8] perf probe: Accept multiple filter options Masami Hiramatsu
2015-04-23 14:55 ` Arnaldo Carvalho de Melo
2015-04-23 23:37 ` Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 4/8] perf probe: Accept filter argument for --list Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 5/8] perf probe: Allow to use filter on --del command Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 6/8] perf probe: Accept filter argument for --funcs Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 7/8] perf probe: Remove redundant cleanup of params.filter Masami Hiramatsu
2015-04-23 13:46 ` [PATCH perf/core v2 8/8] perf probe: Cleanup and consolidate command parsers Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-b3ac032b7a76fea678de225d26ae04d10e47f0ac@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.